Skip to content

Conversation

monotek
Copy link

@monotek monotek commented Aug 25, 2025

Description

  • adjust operator helm chart labels
    • added helm default labels everywhere
    • removed "control-plane: controller-manager" label
    • added labels to crds too
  • shortened resource names (see error below)
  • combined rbac settings in single template file rbac.yaml and removed some code duplication
  • renamed template files for better readability
  • add "---" as prefix for all yaml files
  • removed superfluous comments from chart.yaml and added some project links
  • fix some markdown issues in the readme
  • change kubeRbacProxy livenesspobe to failureThreshold: 5 (liveness and readinessprobe should never be the same)

Issues Resolved

  • resources without labels fixed
    • might not be deinstalled correctly by helm
    • can't be easily selected with "kubectl -l label=value"
  • to long resoure names fixed:
helm upgrade -i opensearch opensearch-operator/opensearch-operator 
Release "opensearch" does not exist. Installing it now.
Error: 1 error occurred:
	* Service "opensearch-opensearch-operator-controller-manager-metrics-service" is invalid: metadata.name: Invalid value: "opensearch-opensearch-operator-controller-manager-metrics-service": must be no more than 63 characters

Check List

  • Commits are signed per the DCO using --signoff
  • Unittest added for the new/changed functionality and all unit tests are successful
  • Customer-visible features documented
  • No linter warnings (make lint)

If CRDs are changed:

  • CRD YAMLs updated (make manifests) and also copied into the helm chart
  • Changes to CRDs documented

Please refer to the PR guidelines before submitting this pull request.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@monotek monotek force-pushed the fix-helm-labels branch 7 times, most recently from 60a490d to bf698fe Compare August 26, 2025 09:43
@monotek monotek changed the title adjust operator helm chart labels adjust operator helm chart labels & resource names Aug 26, 2025
@monotek monotek force-pushed the fix-helm-labels branch 5 times, most recently from a83f357 to 50a13e0 Compare August 27, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant