Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.7 #14

Closed
wants to merge 81 commits into from
Closed

2.7 #14

wants to merge 81 commits into from

Conversation

macohen
Copy link
Collaborator

@macohen macohen commented Jul 11, 2023

Description

Mostly updated to be compatible with OpenSearch 2.7. It doesn't publish an artifact yet, but does use some of the standard build conventions as the rest of OpenSearch. Not sure this should be merged to main until we're comfortable and it won't break the regular build process in main.

Issues Resolved

None exactly. Should start creating issues for more work.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

mapping from: /compiler.*/, to: 'lucene'
}

sourceSets {
Copy link

@hasnain2808 hasnain2808 Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @macohen

I am trying to understand why have we replaced the sourceSets with this

The change ``` sourceSets { main { resources { srcDirs = ["config"] includes = ["**/*.yml"] } } } ```

I am unable to run the plugin locally (both debug and normal mode) due to this change
It is unable to access the mapping file "fstore-index-mapping.json"

Exact eror ``` { "error": { "root_cause": [ { "type": "illegal_state_exception", "reason": "failed to create ltr feature store index with resource [fstore-index-mapping.json]" } ], "type": "illegal_state_exception", "reason": "failed to create ltr feature store index with resource [fstore-index-mapping.json]", "caused_by": { "type": "null_pointer_exception", "reason": null } }, "status": 500 } ```

Without this change I am able to create .ltrstore

I might have missed details, I am starting to get my hands dirty

This PR demonstrates it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR was merged

@hasnain2808 hasnain2808 mentioned this pull request Oct 22, 2023
Merged
@macohen
Copy link
Collaborator Author

macohen commented Oct 26, 2023

@gsingers would you be able to take a pass at a review here? I'd like to merge this and then create a 2.11 branch from this one. Do you see value in 2.8, 2.9, 2.10 releases for this plugin? I'd rather just skip ahead to the latest and move forward from there, but would like your input.

@@ -25,7 +25,7 @@ jobs:
- name: Grant execute permission for gradlew
run: chmod +x gradlew
- name: Build with Gradle
run: ./gradlew -Dtests.security.manager=false build
run: ./gradlew -Dskip.integtests=true -Djava.security.manager=allow -Dbuild.snapshot=false
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipping integ tests is temporary until we can build some more (might be able to remove). allowing the security manager and changes to the plugin-security.policy removed securitymanager violations.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TermStatQuery tests also pass now.

@gsingers
Copy link
Collaborator

@macohen I will take a look next week.

aparo and others added 21 commits January 14, 2024 19:03
Signed-off-by: Mark Cohen <[email protected]>
… implementations, which are going to require some more work

Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
gsingers and others added 27 commits January 14, 2024 19:03
Get releases working

Signed-off-by: Mark Cohen <[email protected]>
* bring in dockerfile

* bring in dockerfile

* add in docker actions

* remove docker branch for push action

Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
…re and a TODO regarding the Strings class

Signed-off-by: Mark Cohen <[email protected]>
… yamlRestTest according to spec. integTests don't work yet so running with the following vars works -Dopensearch.version=2.7.0 -Dskip.integtests=true -Djava.security.manager=allow -Dbuild.snapshot=false

buid.snapshot runs the yamlRestTest successfully. -Djava.security.manager=allow allows the deprecated SecurityManager to do it's work

also updated StoredFeatureParserTests.writeAsNonFormattedString to require MediaType as per opensearch-project/OpenSearch@f9eb9bf

Signed-off-by: Mark Cohen <[email protected]>
' as a branch to trigger when a tag is pushed

Signed-off-by: Mark Cohen <[email protected]>
… opensearch version on command line instead of in gradle.properties

Signed-off-by: Mark Cohen <[email protected]>
…is too general by subbing the semantic-ish versioning regex with a .*, but the build succeeded...

Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mohammad Hasnain Mohsin Rajan <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
…all out that we need to read it to ensure it's at least not a security issue

Signed-off-by: Mark Cohen <[email protected]>
… docker hub doesn't work right now

Signed-off-by: Mark Cohen <[email protected]>
…ToRankPluginIT.java to look for 'ltr' in the response

Signed-off-by: Mark Cohen <[email protected]>
@macohen macohen closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants