Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding sstults to CODEOWNERS #47

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

macohen
Copy link
Collaborator

@macohen macohen commented Oct 1, 2024

Description

Completing adding @sstults as a maintainer. CODEOWNERS must be updated with the MAINTAINERS.md file.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@macohen macohen requested a review from gsingers as a code owner October 1, 2024 21:40
@macohen
Copy link
Collaborator Author

macohen commented Oct 1, 2024

@opensearch-project/admin can you please give @sstults the permissions to maintain this repo?

@gaiksaya
Copy link
Member

gaiksaya commented Oct 2, 2024

@opensearch-project/admin can you please give @sstults the permissions to maintain this repo?

Hi @macohen
Can you please confirm we have required votes and 0 vetos from current maintainers?
Thanks!

@macohen
Copy link
Collaborator Author

macohen commented Oct 2, 2024

@gaiksaya, I can confirm that on behalf of myself and @gsingers. Thanks!

@rishabh6788
Copy link

Checking with OSPO on new guidelines for adding external maintainers.

@rishabh6788
Copy link

@sstults has been added as maintainer, pending acceptance from him.
Screenshot 2024-10-02 at 11 14 13 AM

@macohen
Copy link
Collaborator Author

macohen commented Oct 4, 2024

@sstults once you accept the invite from github as a maintainer on the repo, the CODEOWNERS file check will update so I can merge this PR and that will complete the process of making you a maintainer. Thanks!

@sstults
Copy link
Collaborator

sstults commented Oct 5, 2024

Thank you @macohen I just did it.

@macohen macohen merged commit d3e1dd1 into opensearch-project:main Oct 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants