Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bump-version script for GNU sed #261

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Jul 6, 2023

Description

There's just so many wonderful flavours of sed 🙃

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use gsed everywhere.

@dblock dblock merged commit b14b8c5 into opensearch-project:main Jul 6, 2023
26 of 34 checks passed
@Xtansia Xtansia deleted the feat/bump-version-workflow branch July 6, 2023 22:49
@Xtansia Xtansia added the backport 1.x Backport to 1.x branch label Jul 6, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 6, 2023
Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit b14b8c5)
Xtansia added a commit that referenced this pull request Jul 6, 2023
Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit b14b8c5)

Co-authored-by: Thomas Farr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x Backport to 1.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants