Fixed bug in ClientBuilder where basic authentication is overridden by connection params #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Salih Candir <[email protected]>
…n by connection params Signed-off-by: Salih Candir <[email protected]>
CSalih
requested review from
VachaShah,
dblock,
harshavamsi and
shyim
as code owners
Signed-off-by: Salih Candir <[email protected]>
Signed-off-by: Salih Candir <[email protected]>
dblock
reviewed
Jul 6, 2023
…request Signed-off-by: Salih Candir <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
============================================
+ Coverage 24.14% 24.16% +0.02%
- Complexity 1937 1938 +1
============================================
Files 246 246
Lines 6863 6865 +2
============================================
+ Hits 1657 1659 +2
Misses 5206 5206
|
dblock
approved these changes
Jul 12, 2023
shyim
approved these changes
Jul 12, 2023
|
Thanks for your work on this! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug in ClientBuilder where basic authentication is overridden when first basic authentication then connection params is set.
Issues Resolved
Fixes #159