Add a proxy for closeCursor for backwards-compatibility. #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
VachaShah,
harshavamsi,
shyim and
saimedhi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
============================================
+ Coverage 22.01% 29.26% +7.25%
- Complexity 2260 2580 +320
============================================
Files 309 354 +45
Lines 9026 10533 +1507
============================================
+ Hits 1987 3083 +1096
- Misses 7039 7450 +411 ☔ View full report in Codecov by Sentry. |
dblock
force-pushed
the
close-cursor-proxy
branch
from
fe19a01
to
fba7d20
Compare
dblock
force-pushed
the
close-cursor-proxy
branch
2 times, most recently
from
e740821
to
c6516ba
Compare
Signed-off-by: dblock <[email protected]>
dblock
force-pushed
the
close-cursor-proxy
branch
from
c6516ba
to
db0a8e6
Compare
shyim
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the next round of code generation in #213 we are loosing a method and changing the behavior of two others wrt
bodyparameters being copied from query to body, as the SQL API has been added to the spec and can now be auto-generated.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.