Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to Gradle 8.8. #82

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Upgraded to Gradle 8.8. #82

merged 1 commit into from
Jun 13, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Jun 11, 2024

Description

From opensearch-project/OpenSearch#13584

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Copy link
Collaborator

reta commented Jun 11, 2024

Apologies @dblock , it needs more time, opensearch-project/OpenSearch#14175, I have to revert it since some plugins are started to fail (it really needs change from OpenSearch core and will start to fail after revert)

@dblock
Copy link
Member Author

dblock commented Jun 11, 2024

Apologies @dblock , it needs more time, opensearch-project/OpenSearch#14175, I have to revert it since some plugins are started to fail (it really needs change from OpenSearch core and will start to fail after revert)

Sounds good, we can block this one.

@dblock dblock marked this pull request as draft June 11, 2024 14:38
@reta reta marked this pull request as ready for review June 13, 2024 17:38
@reta reta merged commit 88c7369 into opensearch-project:main Jun 13, 2024
8 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Jun 13, 2024
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-82-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 88c7369e95fcbb54ed680b9dc5d59f611c01c7b7
# Push it to GitHub
git push --set-upstream origin backport/backport-82-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-82-to-2.x.

@reta
Copy link
Collaborator

reta commented Jun 13, 2024

@dblock mind please taking a backport to 2.x?

@dblock dblock deleted the gradle-8.8 branch June 14, 2024 13:08
dblock pushed a commit to dblock/opensearch-plugin-template-java that referenced this pull request Jun 14, 2024
Upgraded to Gradle 8.8.

(cherry picked from commit 88c7369)
@dblock dblock mentioned this pull request Jun 14, 2024
@dblock
Copy link
Member Author

dblock commented Jun 14, 2024

@dblock mind please taking a backport to 2.x?

#88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants