Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build check against next development snapshots #86

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Jun 11, 2024

Description

Add build check against next development snapshots

Issues Resolved

Follow up on #71 (comment)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Show resolved Hide resolved
.github/workflows/CI.yml Show resolved Hide resolved
Co-authored-by: Ralph Ursprung <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking, can we have two lines

./gradlew updateVersion ...
./gradelw build 

It will be a cleaner diff when the version is incremented.

Wonder whether we should extract the version into a .properties file ...

@reta
Copy link
Collaborator Author

reta commented Jun 11, 2024

Nitpicking, can we have two lines

That I think will lead to the issue #60, the && ensures that the both commands succeed

@reta reta merged commit 594c1aa into opensearch-project:2.x Jun 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants