Improve cov

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>
opensearch-project · Jul 14, 2023 · 33940bb · 33940bb
1 parent 4017f6b
commit 33940bb
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 14 deletions.
diff --git a/opensearch_py_ml/ml_models/sentencetransformermodel.py b/opensearch_py_ml/ml_models/sentencetransformermodel.py
@@ -1080,7 +1080,7 @@ def make_model_config_json(
                 normalize_result = True
             else:
                 normalize_result = False
-                
+
         model_config_content = {
             "name": model_name,
             "version": version_number,
@@ -1091,7 +1091,7 @@ def make_model_config_json(
                 "embedding_dimension": embedding_dimension,
                 "framework_type": "sentence_transformers",
                 "pooling_mode": pooling_mode,
-                "normalize_result": normalize_result
+                "normalize_result": normalize_result,
                 "all_config": json.dumps(all_config),
             },
         }

diff --git a/tests/ml_commons/test_ml_commons_client.py b/tests/ml_commons/test_ml_commons_client.py
@@ -303,6 +303,7 @@ def test_integration_model_train_register_full_cycle():
         zip_file_name=MODEL_FILE_ZIP_NAME,
         num_epochs=1,
         overwrite=True,
+        verbose=True,
     )
     # second generating the config file to create metadoc of the model in opensearch.
     test_model.make_model_config_json()

diff --git a/tests/ml_models/test_sentencetransformermodel_pytest.py b/tests/ml_models/test_sentencetransformermodel_pytest.py
@@ -8,7 +8,6 @@
 import json
 import os
 import shutil
-from zipfile import ZipFile
 
 import pytest
 
@@ -107,17 +106,6 @@ def test_missing_files():
 
     with pytest.raises(FileNotFoundError):
         test_model.read_queries(read_path="1234")
-
-    with pytest.raises(Exception) as exc_info:
-        empty_test_path = os.path.join(
-            os.path.dirname(os.path.abspath("__file__")),
-            "tests",
-            "empty_test_file.zip",
-        )
-        with ZipFile(empty_test_path, 'w') as file:
-            pass
-        test_model.read_queries(empty_test_path)
-        clean_test_folder(empty_test_path)
 
     # test synthetic queries already exists in folder
     with pytest.raises(Exception) as exc_info: