Fix typo in model listing workflow (#246)

* Update model_uploader.yml Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Update model_listing_uploader.yml Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Update update_model_listing.yml Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Update update_model_listing.yml Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Update update_model_listing.yml Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> --------- Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>
opensearch-project · Aug 23, 2023 · 4b96617 · 4b96617
1 parent bf3eed3
commit 4b96617
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/update_model_listing.yml b/.github/workflows/update_model_listing.yml
@@ -11,7 +11,6 @@ jobs:
       pull-requests: write
     environment: opensearch-py-ml-cicd-env
     env:
-      bucket_model_listing_file_path: ml-models/model_listing/pre_trained_models.json
       repo_model_listing_path: ./utils/model_uploader/model_listing/pretrained_model_listing.json
       path_prefixes: "ml-models/huggingface/" 
       # To expand the model listing to encompass additional folders, simply adjust the path_prefixes as indicated below: 
@@ -35,7 +34,7 @@ jobs:
         path_prefixes="${{ env.path_prefixes }}"
         for prefix in $path_prefixes
         do
-          if aws s3 ls s3://${{ secrets.PERSONAL_MODEL_BUCKET }}/$prefix > /dev/null
+          if aws s3 ls s3://${{ secrets.MODEL_BUCKET }}/$prefix > /dev/null
           then
             aws s3api list-objects --bucket ${{ secrets.MODEL_BUCKET }} --prefix $prefix --query "Contents[].{Key: Key}" --output text | grep "/config.json$" >> config_paths.txt
           else

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Handle the case when the model max length is undefined in tokenizer by @thanawan-atc in ([#219](https://github.com/opensearch-project/opensearch-py-ml/pull/219))
 - Change to use tokenCredentialId for triggering ml-models-release via generic webhook by @thanawan-atc in ([#240](https://github.com/opensearch-project/opensearch-py-ml/pull/240))
 - Fix typo in model/model-listing workflows by @thanawan-atc in ([#244](https://github.com/opensearch-project/opensearch-py-ml/pull/244))
+- Fix typo in model-listing workflows by @thanawan-atc in ([#246](https://github.com/opensearch-project/opensearch-py-ml/pull/246))
 
 ## [1.1.0]