Skip to content

Commit

Permalink
Fix MLCommonClient_client.upload_model (#336)
Browse files Browse the repository at this point in the history
* fix

Signed-off-by: kalyan <[email protected]>

* fix lint

Signed-off-by: kalyan <[email protected]>

* update changelog

Signed-off-by: kalyan <[email protected]>

* update changelog

Signed-off-by: kalyan <[email protected]>

---------

Signed-off-by: kalyan <[email protected]>
  • Loading branch information
rawwar authored Nov 6, 2023
1 parent 4a8a3e7 commit fc698a7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Roll over pretrained_model_listing.json because of ml-commons dependency by @thanawan-atc in ([#252](https://github.com/opensearch-project/opensearch-py-ml/pull/252))
- Fix pandas dependency issue in nox session by installing pandas package to python directly by @thanawan-atc in ([#266](https://github.com/opensearch-project/opensearch-py-ml/pull/266))
- Fix conditional job execution issue in model upload workflow by @thanawan-atc in ([#294](https://github.com/opensearch-project/opensearch-py-ml/pull/294))
- fix bug in `MLCommonClient_client.upload_model` by @rawwar in ([#336](https://github.com/opensearch-project/opensearch-py-ml/pull/336))

## [1.1.0]

Expand Down
4 changes: 3 additions & 1 deletion opensearch_py_ml/ml_commons/ml_commons_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,9 @@ def upload_model(
:rtype: string
"""
model_id = self._model_uploader._register_model(
model_path, model_config_path, isVerbose
model_path=model_path,
model_meta_path=model_config_path,
isVerbose=isVerbose,
)

# loading the model chunks from model index
Expand Down

0 comments on commit fc698a7

Please sign in to comment.