-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ModelUploader bug & Update demo_tracing_model_torchscript_onxx.ipnyb to use register function #185
Fix ModelUploader bug & Update demo_tracing_model_torchscript_onxx.ipnyb to use register function #185
Conversation
Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>
…tion Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>
Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>
We also need to add a changelog. An workflow is failing: https://github.com/opensearch-project/opensearch-py-ml/actions/runs/5407865644/jobs/9843236489?pr=185 You need to add a section here [Fixed in 1.1.0]: https://github.com/opensearch-project/opensearch-py-ml/blob/main/CHANGELOG.md LMK if you have any question. |
Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>
Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #185 +/- ##
=======================================
Coverage 90.80% 90.81%
=======================================
Files 37 37
Lines 4047 4050 +3
=======================================
+ Hits 3675 3678 +3
Misses 372 372
|
Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>
…nyb to use register function (#185) * Fix bug in ModelUploader by adding MODEL_CONTENT_SIZE_IN_BYTES_FIELD Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Update demo_tracing_model_torchscript_onxx.ipnyb to use register function Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Change folder names Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Correct CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> --------- Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> (cherry picked from commit 976a512)
…nyb to use register function (#185) (#187) * Fix bug in ModelUploader by adding MODEL_CONTENT_SIZE_IN_BYTES_FIELD Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Update demo_tracing_model_torchscript_onxx.ipnyb to use register function Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Change folder names Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Correct CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> --------- Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> (cherry picked from commit 976a512) Co-authored-by: Thanawan Atchariyachanvanit <[email protected]>
Description
ModelUploader
addmodel_content_size_in_bytes
field to model config file so that there is no error whenregister_model
is invoked because ofmodel_content_size_in_bytes
beingnull
.demo_tracing_model_torchscript_onxx.ipnyb
to useregister_model
functionIssues Resolved
#184
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.