Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ModelUploader bug & Update demo_tracing_model_torchscript_onxx.ipnyb to use register function #185

Merged
merged 6 commits into from
Jun 30, 2023

Conversation

thanawan-atc
Copy link
Contributor

@thanawan-atc thanawan-atc commented Jun 29, 2023

Description

  • Have ModelUploader add model_content_size_in_bytes field to model config file so that there is no error when register_model is invoked because of model_content_size_in_bytes being null.
  • Update demo_tracing_model_torchscript_onxx.ipnyb to use register_model function

Issues Resolved

#184

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>
@dhrubo-os
Copy link
Collaborator

We also need to add a changelog.

An workflow is failing: https://github.com/opensearch-project/opensearch-py-ml/actions/runs/5407865644/jobs/9843236489?pr=185

You need to add a section here [Fixed in 1.1.0]: https://github.com/opensearch-project/opensearch-py-ml/blob/main/CHANGELOG.md

LMK if you have any question.

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>
Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #185 (8d61d11) into main (03199fb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   90.80%   90.81%           
=======================================
  Files          37       37           
  Lines        4047     4050    +3     
=======================================
+ Hits         3675     3678    +3     
  Misses        372      372           
Impacted Files Coverage Δ
opensearch_py_ml/ml_commons/ml_common_utils.py 100.00% <100.00%> (ø)
opensearch_py_ml/ml_commons/model_uploader.py 97.50% <100.00%> (+0.06%) ⬆️

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>
@dhrubo-os dhrubo-os merged commit 976a512 into opensearch-project:main Jun 30, 2023
13 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 30, 2023
…nyb to use register function (#185)

* Fix bug in ModelUploader by adding MODEL_CONTENT_SIZE_IN_BYTES_FIELD

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>

* Update demo_tracing_model_torchscript_onxx.ipnyb to use register function

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>

* Correct linting

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>

* Change folder names

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>

* Correct CHANGELOG.md

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>

---------

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>
(cherry picked from commit 976a512)
dhrubo-os pushed a commit that referenced this pull request Jul 1, 2023
…nyb to use register function (#185) (#187)

* Fix bug in ModelUploader by adding MODEL_CONTENT_SIZE_IN_BYTES_FIELD

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>

* Update demo_tracing_model_torchscript_onxx.ipnyb to use register function

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>

* Correct linting

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>

* Change folder names

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>

* Correct CHANGELOG.md

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>

---------

Signed-off-by: Thanawan Atchariyachanvanit <[email protected]>
(cherry picked from commit 976a512)

Co-authored-by: Thanawan Atchariyachanvanit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants