[Backport 1.x] Make make_model_config_json function more concise
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Edit make_model_config_json function Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Improve cov Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Improve cov Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Improve cov (2) Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> --------- Signed-off-by: Thanawan Atchariyachanvanit <[email protected]> (cherry picked from commit 7622af5)
dhrubo-os
approved these changes
Jul 18, 2023
Codecov Report
@@ Coverage Diff @@
## 1.x #194 +/- ##
==========================================
+ Coverage 90.96% 91.06% +0.10%
==========================================
Files 37 37
Lines 4073 4052 -21
==========================================
- Hits 3705 3690 -15
+ Misses 368 362 -6
|
rbhavna
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 7622af5 from #191