[Fix] Model uploader's jekins trigger parameter fix #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… customize prefix. Signed-off-by: conggguan <[email protected]>
conggguan
requested review from
dhrubo-os,
greaa-aws,
ylwu-amzn,
b4sjoo,
jngz-es and
rbhavna
as code owners
Signed-off-by: conggguan <[email protected]>
conggguan
force-pushed
the
uploader-jekins-fix
branch
from
480e7cf
to
d134be6
Compare
dhrubo-os
reviewed
Aug 7, 2024
| if [[ -n "${{ github.event.inputs.upload_prefix }}" ]]; then | ||
| model_prefix="ml-models/${{ github.event.inputs.model_source }}/${{ github.event.inputs.upload_prefix }}" | ||
| else | ||
| model_prefix="ml-models/${{ github.event.inputs.model_source }}/${model_id%%/*}" | ||
| fi | ||
| echo "model_folder=$model_prefix/${model_id##*/}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
what is ##* about? Can we add comment?
There was a problem hiding this comment.
"##" is used to match the longest {*/}.
For example:
model_id="opensearch-project/opensearch-neural-sparse-encoding-v1/tree/main"
output="${model_id##*/}"
echo $outputwill generate a main, because the ##*/ matched the "opensearch-project/opensearch-neural-sparse-encoding-v1/tree/" and deleted it.
There was a problem hiding this comment.
Please add a comment in the code, what does the model_folder look like for both cases (if and else)
…ders]. Signed-off-by: conggguan <[email protected]>
dhrubo-os
reviewed
Aug 7, 2024
|
|
||
| ### Fixed | ||
| - Fix the wrong input parameter for model_uploader's base_download_path in jekins trigger.([#402](https://github.com/opensearch-project/opensearch-py-ml/pull/402)) |
dhrubo-os
approved these changes
Aug 8, 2024
rbhavna
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current model upload workflow has a parameter which can customize the prefix of the upload path. But the Jekins's release workflow are miss this point so that will failed.
In this PR, removed the redundant failed model update information and fixed this bug.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.