Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Initial Hello World Extension integration test #881

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

ryanbogan
Copy link
Member

Description

Sets ./gradle check to depend on integTest task. Adds an integration test to send an initialization request from OpenSearch to the hello world extension.

Additionally this PR removes the TransportCommunicationIT test class as this will need to be redone.

Backport of #874

Issues Resolved

#867

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ryanbogan
Copy link
Member Author

@reta I believe this is failing due to a gradle update, but I can't figure out how to fix it. Any ideas?

@dbwiddis
Copy link
Member

I first saw this symptom in the Gradle 8.2 version bump (#855).

org.gradle.api.GradleException: Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0
        at org.gradle.internal.featurelifecycle.LoggingDeprecatedFeatureHandler.displayDeprecationIfSameMessageNotDisplayedBefore(LoggingDeprecatedFeatureHandler.java:90)
        at org.gradle.internal.featurelifecycle.LoggingDeprecatedFeatureHandler.featureUsed(LoggingDeprecatedFeatureHandler.java:75)
        at org.gradle.internal.deprecation.DeprecationLogger.nagUserWith(DeprecationLogger.java:347)
        at org.gradle.internal.deprecation.DeprecationLogger.nagUserWith(DeprecationLogger.java:246)
        at org.gradle.internal.deprecation.DeprecationMessageBuilder$WithDocumentation.nagUser(DeprecationMessageBuilder.java:130)
        at org.gradle.api.internal.project.DefaultProject.getConvention(DefaultProject.java:593)

I know there's a deprecation warning which is fine but it seems it's throwing an uncaught exception failing builds. This is supposed to be a 9.0 warning, not "we're no longer backwards compatible starting with 8.2."

It seems to be transient, sometimes builds work.

I've searched for bugs at Gradle and not seen any.

I think options include:

  • downgrade to Gradle 8.1
  • fix OpenSearch Gradle Plugin to remove the deprecated features

@reta
Copy link
Contributor

reta commented Jul 14, 2023

@ryanbogan @dbwiddis we've never updated Gradle on OpenSearch 1.x because update to 8.x was breaking things (like this one, so if we would, we would have broken all plugins) :(

@dbwiddis
Copy link
Member

@reta our 1.x is OpenSearch 2.x.

@reta
Copy link
Contributor

reta commented Jul 14, 2023

@reta our 1.x is OpenSearch 2.x

Oh, sorry about that, I will take a look shortly

@reta
Copy link
Contributor

reta commented Jul 14, 2023

@ryanbogan @dbwiddis please use 2.10.0-SNAPSHOT, the Gradle 8.2.1 was not merged into 2.9

        opensearch_version = System.getProperty("opensearch.version", "2.10.0-SNAPSHOT")

@owaiskazi19
Copy link
Member

owaiskazi19 commented Jul 14, 2023

@ryanbogan @dbwiddis please use 2.10.0-SNAPSHOT, the Gradle 8.2.1 was not merged into 2.9

        opensearch_version = System.getProperty("opensearch.version", "2.10.0-SNAPSHOT")

Thanks @reta for looking into it. We are planning to release SDK from 1.x branch with 2.9.0 of OpenSearch though. @ryanbogan I think we should match the gradle version of OpenSearch 2.9 in 1.x of SDK. Can you take care of that?

@ryanbogan
Copy link
Member Author

Seems like we need to downgrade the gradle version for the SDK for 2.9 then

@ryanbogan
Copy link
Member Author

PR here: #884

@ryanbogan ryanbogan merged commit c4e343e into 1.x Jul 14, 2023
7 checks passed
@ryanbogan ryanbogan deleted the backport/backport-874-to-1.x branch July 14, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants