Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ppl patterns command #627

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Conversation

YANG-DB
Copy link
Member

@YANG-DB YANG-DB commented Sep 7, 2024

Description

Add patterns command using the next OpenSearch PPL functionality

Do you have any additional context?

Issues Resolved

#462

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@YANG-DB YANG-DB added Lang:PPL Pipe Processing Language support backport 0.5 backport 0.5-nexus labels Sep 7, 2024
Signed-off-by: YANGDB <[email protected]>
* @return list of names of the derived fields
*/
public static List<String> getNamedGroupCandidates(String pattern) {
public static List<String> getNamedGroupCandidates(String pattern, Map<String, Literal> arguments) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Seems you are unifying the method signature. Why not add some abstract methods in ParseExpression just like parseValue does? Otherwise, the current class ParseExpression is too simple and unnecessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the rests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll completely remove the class hierarchy and remain with a simple functional composition

@YANG-DB YANG-DB merged commit fd3f82f into opensearch-project:main Sep 10, 2024
4 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 10, 2024
* add patterns support & tests

Signed-off-by: YANGDB <[email protected]>

* update tests

Signed-off-by: YANGDB <[email protected]>

* remove unrelated Dockerfile

Signed-off-by: YANGDB <[email protected]>

* sbt format

Signed-off-by: YANGDB <[email protected]>

* fix ParseUtils and simplify different pase expressions according to PR comments feedback

Signed-off-by: YANGDB <[email protected]>

---------

Signed-off-by: YANGDB <[email protected]>
(cherry picked from commit fd3f82f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link

The backport to 0.5-nexus failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.5-nexus 0.5-nexus
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.5-nexus
# Create a new branch
git switch --create backport/backport-627-to-0.5-nexus
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fd3f82fc16273d47f17aa47e699aeaa8b4c3679d
# Push it to GitHub
git push --set-upstream origin backport/backport-627-to-0.5-nexus
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.5-nexus

Then, create a pull request where the base branch is 0.5-nexus and the compare/head branch is backport/backport-627-to-0.5-nexus.

YANG-DB pushed a commit that referenced this pull request Sep 11, 2024
* add patterns support & tests



* update tests



* remove unrelated Dockerfile



* sbt format



* fix ParseUtils and simplify different pase expressions according to PR comments feedback



---------


(cherry picked from commit fd3f82f)

Signed-off-by: YANGDB <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 0.5-nexus backport 0.5 Lang:PPL Pipe Processing Language support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants