Disallow queries that reference catalog views #641
Conversation
eirsep
requested review from
dai-chen,
rupal-bq,
vamsi-amazon,
penghuo,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
eirsep
force-pushed
the
disallow_views
branch
from
f7aef5d
to
b85a122
Compare
Signed-off-by: Surya Sashank Nistala <[email protected]>
eirsep
force-pushed
the
disallow_views
branch
from
b85a122
to
ffe721a
Compare
| @@ -18,5 +18,7 @@ class FlintPPLSparkExtensions extends (SparkSessionExtensions => Unit) { | |||
| extensions.injectParser { (spark, parser) => | |||
| new FlintSparkPPLParser(parser) | |||
| } | |||
|
|
|||
|
|
|||
project/build.properties
Outdated
| @@ -1 +1 @@ | |||
| sbt.version = 1.8.2 | |||
| sbt.version = 1.10.1 | |||
There was a problem hiding this comment.
Can we ignore this file?
Signed-off-by: Surya Sashank Nistala <[email protected]>
There was a problem hiding this comment.
The code looks good.
While "Disable View Access" is a valid feature from a Managed Service perspective, it is not directly related to the core functionality of the opensearch-spark repository, which primarily provides a Spark Accelerator framework for enabling secondary indices to remote data stores.
Would it make sense to implement this feature in a separate repository?
|
As @penghuo mentioned above, the changes are not directly related to Flint but it will disallow any SQL view created in Flint? I assume this is actually not the requirement for Flint Spark extension. I thought we just want to disable Glue Catalog View which may have the issue reported. |
@dai-chen What additional check can I add to ensure the View is actually a Glue catalog view? |
Description
Disallow queries that reference catalog views
Issues Resolved
#534
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.