Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Guava from buildscript dependencies #39

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Remove Guava from buildscript dependencies #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ buildscript {
mavenCentral()
maven { url "https://aws.oss.sonatype.org/content/repositories/snapshots" }
}

dependencies {
classpath group: 'com.google.guava', name: 'guava', version: '30.1-jre'
}
}

plugins {
Expand Down Expand Up @@ -91,7 +87,7 @@ dependencies {
implementation "org.jooq:jooq:3.10.8"
implementation "com.fasterxml.jackson.core:jackson-annotations:${jacksonVersion}"
implementation "com.fasterxml.jackson.core:jackson-databind:${jacksonDataBindVersion}"
implementation 'com.google.guava:guava:31.1-jre'
implementation 'com.google.guava:guava:32.0.1-jre'
implementation 'com.google.code.gson:gson:2.9.0'
implementation group: 'org.apache.logging.log4j', name: 'log4j-api', version: "${log4jVersion}"
implementation group: 'org.apache.logging.log4j', name: 'log4j-core', version: "${log4jVersion}"
Expand Down
12 changes: 8 additions & 4 deletions src/main/java/org/opensearch/performanceanalyzer/commons/jvm/ThreadList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,10 @@ private static void parseThreadInfo(final ThreadInfo info) {
if (arr != null) {
// We need to get the value of blocked time per interval rather than per second.
// (i.e How many seconds the thread was blocked in last sampling interval.
// So if the blocked time for last 5 seconds interval was 3 seconds we will calculate the value as 3 seconds instead of 3/5 seconds.)
// This is resulting in lower blocked time during the Total sum calculation for past 1 minute in ThreadMetricsRca
// So if the blocked time for last 5 seconds interval was 3 seconds we will
// calculate the value as 3 seconds instead of 3/5 seconds.)
// This is resulting in lower blocked time during the Total sum calculation for
// past 1 minute in ThreadMetricsRca
t.avgBlockedTime = 1.0 * arr.getAvgValue() / MILLIS_PER_SECOND;
}
}
Expand All @@ -295,8 +297,10 @@ private static void parseThreadInfo(final ThreadInfo info) {
if (arr != null) {
// We need to get the value of waited time per interval rather than per second.
// (i.e How many seconds the thread was waiting in last sampling interval.
// So if the waited time for last 5 seconds interval was 3 seconds we will calculate the value as 3 seconds instead of 3/5 seconds.)
// This is resulting in lower waited time during the Total sum calculation for past 1 minute in ThreadMetricsRca
// So if the waited time for last 5 seconds interval was 3 seconds we will
// calculate the value as 3 seconds instead of 3/5 seconds.)
// This is resulting in lower waited time during the Total sum calculation for
// past 1 minute in ThreadMetricsRca
t.avgWaitedTime = 1.0 * arr.getAvgValue() / MILLIS_PER_SECOND;
}
}
Expand Down
8 changes: 3 additions & 5 deletions src/main/java/org/opensearch/performanceanalyzer/commons/metrics/AllMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,13 +1040,11 @@ public static class Constants {
public static final String SEARCHBP_SEARCH_BACK_PRESSURE_STATS_SEARCH_TASK_STATS =
"searchTaskStats";


/**
* Add SEARCHBP_TABLE_NAME for searchbackpressureRCA to find the corresponding table
*/
/** Add SEARCHBP_TABLE_NAME for searchbackpressureRCA to find the corresponding table */
public static final String SEARCHBP_TABLE_NAME = "Searchbp_Stats";
/**
* Add SEARCHBP_TYPE_DIM for searchbackpressureRCA to find the cell value for each stats type
* Add SEARCHBP_TYPE_DIM for searchbackpressureRCA to find the cell value for each stats
* type
*/
public static final String SEARCHBP_TYPE_DIM = "SearchBackPressureStats";
}
Expand Down
Loading