[Request] Adds CacheConfig Telemetry collectors #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atharvasharma61
requested review from
khushbr,
ansjcy,
sbcd90,
Shephalimittal,
nishchay21,
rramachand21,
psychbot and
Gaganjuneja
as code owners
nishchay21
reviewed
Jul 24, 2024
.../org/opensearch/performanceanalyzer/collectors/telemetry/RTFCacheConfigMetricsCollector.java
Outdated
Show resolved
Hide resolved
.../org/opensearch/performanceanalyzer/collectors/telemetry/RTFCacheConfigMetricsCollector.java
Outdated
Show resolved
Hide resolved
...main/java/org/opensearch/performanceanalyzer/collectors/telemetry/RTFOSMetricsCollector.java
Outdated
Show resolved
Hide resolved
atharvasharma61
changed the title
Gaganjuneja
reviewed
Sep 2, 2024
.../org/opensearch/performanceanalyzer/collectors/telemetry/RTFCacheConfigMetricsCollector.java
Outdated
Show resolved
Hide resolved
Gaganjuneja
approved these changes
Sep 2, 2024
|
Please see why the build is failing? |
atharvasharma61
force-pushed
the
new-collectors
branch
from
80ad8bf
to
4f3f508
Compare
|
Seeing build failures in previous merged commits as well due to some docker compose related failure. Will need to check that up separately |
Signed-off-by: Atharva Sharma <[email protected]>
atharvasharma61
force-pushed
the
new-collectors
branch
from
4f3f508
to
3919c4a
Compare
psychbot
approved these changes
Sep 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
(cherry picked from commit 2624469)
atharvasharma61
added a commit
to atharvasharma61/performance-analyzer
that referenced
this pull request
Sep 4, 2024
Signed-off-by: Atharva Sharma <[email protected]>
5 tasks
ansjcy
pushed a commit
that referenced
this pull request
Sep 4, 2024
(cherry picked from commit 2624469) Co-authored-by: Atharva Sharma <[email protected]>
atharvasharma61
added a commit
to atharvasharma61/performance-analyzer
that referenced
this pull request
Sep 5, 2024
…ect#710) (cherry picked from commit 2624469) Co-authored-by: Atharva Sharma <[email protected]>
atharvasharma61
added a commit
to atharvasharma61/performance-analyzer
that referenced
this pull request
Sep 5, 2024
…ect#710) (cherry picked from commit 2624469) Co-authored-by: Atharva Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you are proposing
Adds CacheConfig Telemetry collectors
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.