Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump java to 21 #1014

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Bump java to 21 #1014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .github/workflows/reports-scheduler-test-and-build-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ jobs:
strategy:
matrix:
java:
- 11
- 17
- 21
runs-on: ubuntu-latest
container:
Expand All @@ -24,6 +22,9 @@ jobs:
# need to switch to root so that github actions can install runner binary on container without permission issues.
options: --user root

env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it shouldn't use node?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is an issue with github runners:

On June 30th 2024, we will change the default from Node16 to Node20.
To opt out of this and continue using Node16 while it is still available in the runner, you can choose to set ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true


steps:
- name: Set up JDK ${{ matrix.java }}
uses: actions/setup-java@v1
Expand Down Expand Up @@ -67,8 +68,6 @@ jobs:
strategy:
matrix:
java:
- 11
- 17
- 21
runs-on: windows-latest

Expand Down Expand Up @@ -100,8 +99,7 @@ jobs:
strategy:
matrix:
java:
- 11
- 17
- 21
runs-on: macos-latest

steps:
Expand Down
Loading