Skip to content

Commit

Permalink
Incorporate changes to SearchPipelinePlugin interface
Browse files Browse the repository at this point in the history
Description:
============
SearchPipelinePlugin interface now uses Processor.Factory<SearchResponseProcessor> instead of Processor.Factory.
Also use getResponseProcessors method instead of getProcessors method.

Check list:
===========
- [x] New functionality includes testing.
  - [x] All tests pass
- [x] New functionality has been documented.
  - [x] New functionality has javadoc added
- [x] Commits are signed as per the DCO using --signoff

Signed-off-by: Ketan Kulkarni <[email protected]>
  • Loading branch information
kulket committed May 23, 2023
1 parent 5ff57cb commit 0472a12
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import org.opensearch.repositories.RepositoriesService;
import org.opensearch.script.ScriptService;
import org.opensearch.search.pipeline.Processor;
import org.opensearch.search.pipeline.SearchResponseProcessor;
import org.opensearch.search.relevance.actionfilter.SearchActionFilter;
import org.opensearch.search.relevance.client.OpenSearchClient;
import org.opensearch.search.relevance.configuration.ResultTransformerConfigurationFactory;
Expand Down Expand Up @@ -114,7 +115,7 @@ public List<SearchExtSpec<?>> getSearchExts() {
}

@Override
public Map<String, Processor.Factory> getProcessors(Processor.Parameters parameters) {
public Map<String, Processor.Factory<SearchResponseProcessor>> getResponseProcessors(Processor.Parameters parameters) {
return Map.of(PersonalizeRankingResponseProcessor.TYPE,
new PersonalizeRankingResponseProcessor.Factory(
PersonalizeClientSettings.getClientSettings(parameters.env.settings())));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public String getDescription() {
return description;
}

public static final class Factory implements Processor.Factory {
public static final class Factory implements Processor.Factory<SearchResponseProcessor> {

PersonalizeClientSettings personalizeClientSettings;

Expand All @@ -144,7 +144,7 @@ public Factory(PersonalizeClientSettings settings) {
}

@Override
public PersonalizeRankingResponseProcessor create(Map<String, Processor.Factory> processorFactories, String tag, String description, Map<String, Object> config) throws Exception {
public PersonalizeRankingResponseProcessor create(Map<String, Processor.Factory<SearchResponseProcessor>> processorFactories, String tag, String description, Map<String, Object> config) throws Exception {
// TODO: Handle validation as well as required vs non required config differentiation with related user error / exception
String personalizeCampaign = ConfigurationUtils.readStringProperty(TYPE, tag, config, CAMPAIGN_ARN_CONFIG_NAME);
String iamRoleArn = ConfigurationUtils.readOptionalStringProperty(TYPE, tag, config, IAM_ROLE_ARN_CONFIG_NAME);
Expand Down

0 comments on commit 0472a12

Please sign in to comment.