Move versioning logic to the root project #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of computing the OpenSearch + plugin version in the subprojects, we can do it in the root project and propagate the `ext` variables. Signed-off-by: Michael Froh <[email protected]>
msfroh
requested review from
macohen,
noCharger,
mingshl and
sejli
as code owners
Codecov Report
@@ Coverage Diff @@
## main #207 +/- ##
=========================================
Coverage 83.30% 83.30%
Complexity 337 337
=========================================
Files 43 43
Lines 1270 1270
Branches 155 155
=========================================
Hits 1058 1058
Misses 134 134
Partials 78 78 |
mingshl
approved these changes
Nov 1, 2023
noCharger
reviewed
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of computing the OpenSearch + plugin version in the subprojects, we can do it in the root project and propagate the
extvariables.Check List
[ ] New functionality includes testing.[ ] All tests pass[ ] New functionality has been documented.[ ] New functionality has javadoc addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.