Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Stephen to Emeritus maintainer #2134

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Oct 9, 2024

Description

Move @stephen-crawford to emeritus maintainer

Category

Maintenance

Why these changes are required?

@stephen-crawford

What is the old behavior before changes and new behavior after changes?

@stephen-crawford

Issues Resolved

None

Testing

None

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.46%. Comparing base (252d8fb) to head (dfcb467).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2134   +/-   ##
=======================================
  Coverage   71.46%   71.46%           
=======================================
  Files          97       97           
  Lines        2649     2649           
  Branches      403      403           
=======================================
  Hits         1893     1893           
  Misses        641      641           
  Partials      115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwperks cwperks added backport 1.3 backport 2.x backport to 2.x branch labels Oct 9, 2024
@cwperks cwperks merged commit 506d803 into opensearch-project:main Oct 9, 2024
19 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-dashboards-plugin/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/security-dashboards-plugin/backport-1.3
# Create a new branch
git switch --create backport/backport-2134-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 506d803b868002f131a65d0d7ad370625454a8e4
# Push it to GitHub
git push --set-upstream origin backport/backport-2134-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-dashboards-plugin/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-2134-to-1.3.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-2134-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 506d803b868002f131a65d0d7ad370625454a8e4
# Push it to GitHub
git push --set-upstream origin backport/backport-2134-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-dashboards-plugin/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2134-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants