[Backport 2.4] [Manual] Make BWC tests work on multi- platform and jdk #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Nied <[email protected]> Remove MacOS support Signed-off-by: Peter Nied <[email protected]> Fix incorrect outputs reference Signed-off-by: Peter Nied <[email protected]> Missed variable replacement Signed-off-by: Peter Nied <[email protected]> Adjust current build dest folder Signed-off-by: Peter Nied <[email protected]> use gradle root-dir instead of cd Signed-off-by: Peter Nied <[email protected]> Add if/else logic to cleanup workflow Source https://stackoverflow.com/a/67291623/533057 Signed-off-by: Peter Nied <[email protected]> Install wget if we are on windows Signed-off-by: Peter Nied <[email protected]> Include executing the wget commands Signed-off-by: Peter Nied <[email protected]> Move to 2.4 Signed-off-by: Peter Nied <[email protected]>
3 tasks
Signed-off-by: Peter Nied <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.4 #2234 +/- ##
============================================
- Coverage 61.04% 61.03% -0.02%
+ Complexity 3249 3247 -2
============================================
Files 258 258
Lines 18123 18123
Branches 3231 3231
============================================
- Hits 11064 11061 -3
- Misses 5488 5491 +3
Partials 1571 1571
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Hmm - slight problem with my design - it requires a 2.3.0 version of the security plugin was built on windows and available for download. I'm going to need to circle back on that issue. |
|
I am going to abandon this pull request, as we do not have supported windows 2.3.0 artifacts following our standard conventions, I'll continue working on the pull request against main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the backward compatibility tests to run on windows in JDK11/17
Issues Resolved
Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.