Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[2.x] Extracts demo configuration setup into a java tool, adds support for Bundled JDK for this tool and updates DEVELOPER_GUIDE.md" #3874

Conversation

derek-ho
Copy link
Collaborator

Reverts #3845

Preparing this revert PR in case we need to unblock folks who get main/2.x CI failures due to this change

…s support for Bundled JDK for this tool and updates DEVELOPER_GUIDE.md (opensearch-project#3845)"

This reverts commit ea9546e.
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45917e9) 65.06% compared to head (814e0b9) 64.90%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #3874      +/-   ##
============================================
- Coverage     65.06%   64.90%   -0.16%     
+ Complexity     3732     3664      -68     
============================================
  Files           297      292       -5     
  Lines         21000    20648     -352     
  Branches       3439     3401      -38     
============================================
- Hits          13663    13402     -261     
+ Misses         5633     5564      -69     
+ Partials       1704     1682      -22     
Files Coverage Δ
...g/opensearch/security/support/ConfigConstants.java 95.23% <ø> (ø)

... and 5 files with indirect coverage changes

@peternied
Copy link
Member

@derek-ho I don't think we need this and its out of date - I'm going to close this and we can reopen if we need it

@peternied peternied closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants