Update PULL_REQUEST_TEMPLATE to include an API spec change in the checklist. #4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cklist. Signed-off-by: dblock <[email protected]>
dblock
requested review from
cliu123,
cwperks,
DarshitChanpura,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
RyanL1997
approved these changes
Jul 8, 2024
22 tasks
reta
approved these changes
Jul 9, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-4533-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4f3ea970914b7b70566e1ec7a73be49d4c8335c4
# Push it to GitHub
git push --set-upstream origin backport/backport-4533-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.xThen, create a pull request where the |
|
Adding a backport label in case there are updates being made directly to 2.x |
DarshitChanpura
pushed a commit
to DarshitChanpura/security
that referenced
this pull request
Jul 9, 2024
…cklist. (opensearch-project#4533) Signed-off-by: dblock <[email protected]> (cherry picked from commit 4f3ea97)
1 task
DarshitChanpura
pushed a commit
to DarshitChanpura/security
that referenced
this pull request
Jul 9, 2024
…cklist. (opensearch-project#4533) Signed-off-by: dblock <[email protected]> (cherry picked from commit 4f3ea97) Signed-off-by: Darshit Chanpura <[email protected]>
willyborankin
pushed a commit
that referenced
this pull request
Jul 9, 2024
…ange in the checklist. (#4533) (#4536) Signed-off-by: dblock <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
prabhask5
pushed a commit
to prabhask5/opensearch-security
that referenced
this pull request
Jul 10, 2024
…cklist. (opensearch-project#4533) Signed-off-by: dblock <[email protected]> Signed-off-by: Prabhas Kurapati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from opensearch-project/opensearch-api-specification#387, update PR template to include a checkbox that requests that all API changes be documented in the OpenAPI spec used to generate clients.