Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename auth failure listeners & add permission support #4713

Merged

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Sep 6, 2024

Description

Renames auth failure listener classes & APIs to a more general name (rate limiters) to support API tokens & other use cases. Adds permission support to these APIs. Removes incorrect debug logging.

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    Enhancement
  • Why these changes are required?
    Fix: [BUG] Auth Failure Listener API follow ups #4712
  • What is the old behavior before changes and new behavior after changes?
    New class names, API routes, permission support, before: none of the above.

Issues Resolved

Fix: #4712

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.
No

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
No

Testing

Existing tests pass

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.53%. Comparing base (4f2e689) to head (fd80383).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4713      +/-   ##
==========================================
+ Coverage   65.22%   65.53%   +0.30%     
==========================================
  Files         318      319       +1     
  Lines       22327    22446     +119     
  Branches     3591     3601      +10     
==========================================
+ Hits        14562    14709     +147     
+ Misses       5968     5929      -39     
- Partials     1797     1808      +11     
Files with missing lines Coverage Δ
...rg/opensearch/security/dlic/rest/api/Endpoint.java 100.00% <100.00%> (ø)
.../security/dlic/rest/api/RateLimitersApiAction.java 85.85% <100.00%> (ø)
...dlic/rest/api/RestApiAdminPrivilegesEvaluator.java 72.54% <100.00%> (+4.62%) ⬆️
...security/dlic/rest/api/SecurityRestApiActions.java 80.00% <ø> (ø)

... and 12 files with indirect coverage changes

@derek-ho derek-ho marked this pull request as ready for review September 6, 2024 17:50
Signed-off-by: Derek Ho <[email protected]>
@cwperks cwperks merged commit c6988fb into opensearch-project:main Sep 12, 2024
42 checks passed
@willyborankin willyborankin added the backport 2.x backport to 2.x branch label Sep 12, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-4713-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c6988fb50ac3847b526529841775efa2cba0bfb5
# Push it to GitHub
git push --set-upstream origin backport/backport-4713-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4713-to-2.x.

@willyborankin
Copy link
Collaborator

@derek-ho and @cwperks what about backport to 2.x?

tmanninger pushed a commit to tmanninger/opensearch-security that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Auth Failure Listener API follow ups
3 participants