Refactor ASN1 call #4729
Merged
Refactor ASN1 call #4729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Terry Quigley <[email protected]>
terryquigleysas
requested review from
cwperks,
DarshitChanpura,
nibix,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
willyborankin
approved these changes
Sep 16, 2024
cwperks
approved these changes
Sep 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
Signed-off-by: Terry Quigley <[email protected]> (cherry picked from commit 7ddbf6a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
tmanninger
pushed a commit
to tmanninger/opensearch-security
that referenced
this pull request
Sep 24, 2024
Signed-off-by: Terry Quigley <[email protected]> Signed-off-by: tmanninger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Category (Enhancement, Refactoring)
With the view of working towards supporting multiple security providers (FIPS and non-FIPS) the call to asn1TaggedObject.getObject() in DefaultSecurityKeyStore can be refactored to support the methods available in either library.
No functionality changes.
Issues Resolved
Resolves #4728
Testing
New test added to code.
Backwards compatibility ensured by existing tests (e.g. SecuritySSLReloadCertsActionTests in particular)
I have also tested against the latest Bouncy Castle 2.x FIPS libraries.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.