[Spotless] Applying Google Code Format for prometheus files #13 (#340) (

#1973) * added ignorefailures * Spotless apply on Prometheus --------- Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
opensearch-project · Aug 16, 2023 · 0dfbc89 · 0dfbc89
1 parent 983d77d
commit 0dfbc89
Show file tree

Hide file tree

Showing 67 changed files with 1,797 additions and 1,695 deletions.
diff --git a/build.gradle b/build.gradle
@@ -86,6 +86,7 @@ spotless {
         target fileTree('.') {
             include 'datasources/**/*.java',
                     'core/**/*.java',
+                    'prometheus/**/*.java',
                     'sql/**/*.java',
                     'common/**/*.java',
                     'ppl/**/*.java'

diff --git a/prometheus/build.gradle b/prometheus/build.gradle
@@ -13,6 +13,9 @@ repositories {
     mavenCentral()
 }
 
+checkstyleTest.ignoreFailures = true
+checkstyleMain.ignoreFailures = true
+
 dependencies {
     api project(':core')
     implementation project(':datasources')

diff --git a/prometheus/src/main/java/org/opensearch/sql/prometheus/client/PrometheusClientImpl.java b/prometheus/src/main/java/org/opensearch/sql/prometheus/client/PrometheusClientImpl.java
@@ -38,60 +38,60 @@ public PrometheusClientImpl(OkHttpClient okHttpClient, URI uri) {
     this.uri = uri;
   }
 
-
   @Override
   public JSONObject queryRange(String query, Long start, Long end, String step) throws IOException {
-    String queryUrl = String.format("%s/api/v1/query_range?query=%s&start=%s&end=%s&step=%s",
-        uri.toString().replaceAll("/$", ""), URLEncoder.encode(query, StandardCharsets.UTF_8),
-        start, end, step);
+    String queryUrl =
+        String.format(
+            "%s/api/v1/query_range?query=%s&start=%s&end=%s&step=%s",
+            uri.toString().replaceAll("/$", ""),
+            URLEncoder.encode(query, StandardCharsets.UTF_8),
+            start,
+            end,
+            step);
     logger.debug("queryUrl: " + queryUrl);
-    Request request = new Request.Builder()
-        .url(queryUrl)
-        .build();
+    Request request = new Request.Builder().url(queryUrl).build();
     Response response = this.okHttpClient.newCall(request).execute();
     JSONObject jsonObject = readResponse(response);
     return jsonObject.getJSONObject("data");
   }
 
   @Override
   public List<String> getLabels(String metricName) throws IOException {
-    String queryUrl = String.format("%s/api/v1/labels?%s=%s",
-        uri.toString().replaceAll("/$", ""),
-        URLEncoder.encode("match[]", StandardCharsets.UTF_8),
-        URLEncoder.encode(metricName, StandardCharsets.UTF_8));
+    String queryUrl =
+        String.format(
+            "%s/api/v1/labels?%s=%s",
+            uri.toString().replaceAll("/$", ""),
+            URLEncoder.encode("match[]", StandardCharsets.UTF_8),
+            URLEncoder.encode(metricName, StandardCharsets.UTF_8));
     logger.debug("queryUrl: " + queryUrl);
-    Request request = new Request.Builder()
-        .url(queryUrl)
-        .build();
+    Request request = new Request.Builder().url(queryUrl).build();
     Response response = this.okHttpClient.newCall(request).execute();
     JSONObject jsonObject = readResponse(response);
     return toListOfLabels(jsonObject.getJSONArray("data"));
   }
 
   @Override
   public Map<String, List<MetricMetadata>> getAllMetrics() throws IOException {
-    String queryUrl = String.format("%s/api/v1/metadata",
-        uri.toString().replaceAll("/$", ""));
+    String queryUrl = String.format("%s/api/v1/metadata", uri.toString().replaceAll("/$", ""));
     logger.debug("queryUrl: " + queryUrl);
-    Request request = new Request.Builder()
-        .url(queryUrl)
-        .build();
+    Request request = new Request.Builder().url(queryUrl).build();
     Response response = this.okHttpClient.newCall(request).execute();
     JSONObject jsonObject = readResponse(response);
-    TypeReference<HashMap<String, List<MetricMetadata>>> typeRef
-        = new TypeReference<>() {};
+    TypeReference<HashMap<String, List<MetricMetadata>>> typeRef = new TypeReference<>() {};
     return new ObjectMapper().readValue(jsonObject.getJSONObject("data").toString(), typeRef);
   }
 
   @Override
   public JSONArray queryExemplars(String query, Long start, Long end) throws IOException {
-    String queryUrl = String.format("%s/api/v1/query_exemplars?query=%s&start=%s&end=%s",
-        uri.toString().replaceAll("/$", ""), URLEncoder.encode(query, StandardCharsets.UTF_8),
-        start, end);
+    String queryUrl =
+        String.format(
+            "%s/api/v1/query_exemplars?query=%s&start=%s&end=%s",
+            uri.toString().replaceAll("/$", ""),
+            URLEncoder.encode(query, StandardCharsets.UTF_8),
+            start,
+            end);
     logger.debug("queryUrl: " + queryUrl);
-    Request request = new Request.Builder()
-        .url(queryUrl)
-        .build();
+    Request request = new Request.Builder().url(queryUrl).build();
     Response response = this.okHttpClient.newCall(request).execute();
     JSONObject jsonObject = readResponse(response);
     return jsonObject.getJSONArray("data");
@@ -100,16 +100,15 @@ public JSONArray queryExemplars(String query, Long start, Long end) throws IOExc
   private List<String> toListOfLabels(JSONArray array) {
     List<String> result = new ArrayList<>();
     for (int i = 0; i < array.length(); i++) {
-      //__name__ is internal label in prometheus representing the metric name.
-      //Exempting this from labels list as it is not required in any of the operations.
+      // __name__ is internal label in prometheus representing the metric name.
+      // Exempting this from labels list as it is not required in any of the operations.
       if (!"__name__".equals(array.optString(i))) {
         result.add(array.optString(i));
       }
     }
     return result;
   }
 
-
   private JSONObject readResponse(Response response) throws IOException {
     if (response.isSuccessful()) {
       JSONObject jsonObject = new JSONObject(Objects.requireNonNull(response.body()).string());
@@ -120,10 +119,9 @@ private JSONObject readResponse(Response response) throws IOException {
       }
     } else {
       throw new RuntimeException(
-          String.format("Request to Prometheus is Unsuccessful with : %s", Objects.requireNonNull(
-              response.body(), "Response body can't be null").string()));
+          String.format(
+              "Request to Prometheus is Unsuccessful with : %s",
+              Objects.requireNonNull(response.body(), "Response body can't be null").string()));
     }
   }
-
-
 }
diff --git a/.../src/main/java/org/opensearch/sql/prometheus/data/constants/PrometheusFieldConstants.java b/.../src/main/java/org/opensearch/sql/prometheus/data/constants/PrometheusFieldConstants.java
@@ -18,6 +18,6 @@ public class PrometheusFieldConstants {
   public static final String EXEMPLARS_KEY = "exemplars";
   public static final String TRACE_ID_KEY = "traceID";
   public static final String LABELS_KEY = "labels";
-  public static final String TIMESTAMP_KEY  = "timestamp";
-  public static final String VALUE_KEY  = "value";
+  public static final String TIMESTAMP_KEY = "timestamp";
+  public static final String VALUE_KEY = "value";
 }
diff --git a/...ensearch/sql/prometheus/functions/implementation/QueryExemplarFunctionImplementation.java b/...ensearch/sql/prometheus/functions/implementation/QueryExemplarFunctionImplementation.java
@@ -28,8 +28,8 @@
 import org.opensearch.sql.prometheus.storage.QueryExemplarsTable;
 import org.opensearch.sql.storage.Table;
 
-public class QueryExemplarFunctionImplementation extends FunctionExpression implements
-    TableFunctionImplementation {
+public class QueryExemplarFunctionImplementation extends FunctionExpression
+    implements TableFunctionImplementation {
 
   private final FunctionName functionName;
   private final List<Expression> arguments;
@@ -39,10 +39,10 @@ public class QueryExemplarFunctionImplementation extends FunctionExpression impl
    * Required argument constructor.
    *
    * @param functionName name of the function
-   * @param arguments    a list of arguments provided
+   * @param arguments a list of arguments provided
    */
-  public QueryExemplarFunctionImplementation(FunctionName functionName, List<Expression> arguments,
-                                          PrometheusClient prometheusClient) {
+  public QueryExemplarFunctionImplementation(
+      FunctionName functionName, List<Expression> arguments, PrometheusClient prometheusClient) {
     super(functionName, arguments);
     this.functionName = functionName;
     this.arguments = arguments;
@@ -51,10 +51,11 @@ public QueryExemplarFunctionImplementation(FunctionName functionName, List<Expre
 
   @Override
   public ExprValue valueOf(Environment<Expression, ExprValue> valueEnv) {
-    throw new UnsupportedOperationException(String.format(
-        "Prometheus defined function [%s] is only "
-            + "supported in SOURCE clause with prometheus connector catalog",
-        functionName));
+    throw new UnsupportedOperationException(
+        String.format(
+            "Prometheus defined function [%s] is only "
+                + "supported in SOURCE clause with prometheus connector catalog",
+            functionName));
   }
 
   @Override
@@ -64,10 +65,15 @@ public ExprType type() {
 
   @Override
   public String toString() {
-    List<String> args = arguments.stream()
-        .map(arg -> String.format("%s=%s", ((NamedArgumentExpression) arg)
-            .getArgName(), ((NamedArgumentExpression) arg).getValue().toString()))
-        .collect(Collectors.toList());
+    List<String> args =
+        arguments.stream()
+            .map(
+                arg ->
+                    String.format(
+                        "%s=%s",
+                        ((NamedArgumentExpression) arg).getArgName(),
+                        ((NamedArgumentExpression) arg).getValue().toString()))
+            .collect(Collectors.toList());
     return String.format("%s(%s)", functionName, String.join(", ", args));
   }
 
@@ -79,27 +85,26 @@ public Table applyArguments() {
   private PrometheusQueryExemplarsRequest buildExemplarsQueryRequest(List<Expression> arguments) {
 
     PrometheusQueryExemplarsRequest request = new PrometheusQueryExemplarsRequest();
-    arguments.forEach(arg -> {
-      String argName = ((NamedArgumentExpression) arg).getArgName();
-      Expression argValue = ((NamedArgumentExpression) arg).getValue();
-      ExprValue literalValue = argValue.valueOf();
-      switch (argName) {
-        case QUERY:
-          request
-              .setQuery((String) literalValue.value());
-          break;
-        case STARTTIME:
-          request.setStartTime(((Number) literalValue.value()).longValue());
-          break;
-        case ENDTIME:
-          request.setEndTime(((Number) literalValue.value()).longValue());
-          break;
-        default:
-          throw new ExpressionEvaluationException(
-              String.format("Invalid Function Argument:%s", argName));
-      }
-    });
+    arguments.forEach(
+        arg -> {
+          String argName = ((NamedArgumentExpression) arg).getArgName();
+          Expression argValue = ((NamedArgumentExpression) arg).getValue();
+          ExprValue literalValue = argValue.valueOf();
+          switch (argName) {
+            case QUERY:
+              request.setQuery((String) literalValue.value());
+              break;
+            case STARTTIME:
+              request.setStartTime(((Number) literalValue.value()).longValue());
+              break;
+            case ENDTIME:
+              request.setEndTime(((Number) literalValue.value()).longValue());
+              break;
+            default:
+              throw new ExpressionEvaluationException(
+                  String.format("Invalid Function Argument:%s", argName));
+          }
+        });
     return request;
   }
-
 }
diff --git a/.../opensearch/sql/prometheus/functions/implementation/QueryRangeFunctionImplementation.java b/.../opensearch/sql/prometheus/functions/implementation/QueryRangeFunctionImplementation.java
@@ -29,8 +29,8 @@
 import org.opensearch.sql.prometheus.storage.PrometheusMetricTable;
 import org.opensearch.sql.storage.Table;
 
-public class QueryRangeFunctionImplementation extends FunctionExpression implements
-    TableFunctionImplementation {
+public class QueryRangeFunctionImplementation extends FunctionExpression
+    implements TableFunctionImplementation {
 
   private final FunctionName functionName;
   private final List<Expression> arguments;
@@ -40,10 +40,10 @@ public class QueryRangeFunctionImplementation extends FunctionExpression impleme
    * Required argument constructor.
    *
    * @param functionName name of the function
-   * @param arguments    a list of expressions
+   * @param arguments a list of expressions
    */
-  public QueryRangeFunctionImplementation(FunctionName functionName, List<Expression> arguments,
-                                          PrometheusClient prometheusClient) {
+  public QueryRangeFunctionImplementation(
+      FunctionName functionName, List<Expression> arguments, PrometheusClient prometheusClient) {
     super(functionName, arguments);
     this.functionName = functionName;
     this.arguments = arguments;
@@ -52,10 +52,11 @@ public QueryRangeFunctionImplementation(FunctionName functionName, List<Expressi
 
   @Override
   public ExprValue valueOf(Environment<Expression, ExprValue> valueEnv) {
-    throw new UnsupportedOperationException(String.format(
-        "Prometheus defined function [%s] is only "
-            + "supported in SOURCE clause with prometheus connector catalog",
-        functionName));
+    throw new UnsupportedOperationException(
+        String.format(
+            "Prometheus defined function [%s] is only "
+                + "supported in SOURCE clause with prometheus connector catalog",
+            functionName));
   }
 
   @Override
@@ -65,10 +66,15 @@ public ExprType type() {
 
   @Override
   public String toString() {
-    List<String> args = arguments.stream()
-        .map(arg -> String.format("%s=%s", ((NamedArgumentExpression) arg)
-            .getArgName(), ((NamedArgumentExpression) arg).getValue().toString()))
-        .collect(Collectors.toList());
+    List<String> args =
+        arguments.stream()
+            .map(
+                arg ->
+                    String.format(
+                        "%s=%s",
+                        ((NamedArgumentExpression) arg).getArgName(),
+                        ((NamedArgumentExpression) arg).getValue().toString()))
+            .collect(Collectors.toList());
     return String.format("%s(%s)", functionName, String.join(", ", args));
   }
 
@@ -80,30 +86,29 @@ public Table applyArguments() {
   private PrometheusQueryRequest buildQueryFromQueryRangeFunction(List<Expression> arguments) {
 
     PrometheusQueryRequest prometheusQueryRequest = new PrometheusQueryRequest();
-    arguments.forEach(arg -> {
-      String argName = ((NamedArgumentExpression) arg).getArgName();
-      Expression argValue = ((NamedArgumentExpression) arg).getValue();
-      ExprValue literalValue = argValue.valueOf();
-      switch (argName) {
-        case QUERY:
-          prometheusQueryRequest
-              .setPromQl((String) literalValue.value());
-          break;
-        case STARTTIME:
-          prometheusQueryRequest.setStartTime(((Number) literalValue.value()).longValue());
-          break;
-        case ENDTIME:
-          prometheusQueryRequest.setEndTime(((Number) literalValue.value()).longValue());
-          break;
-        case STEP:
-          prometheusQueryRequest.setStep(literalValue.value().toString());
-          break;
-        default:
-          throw new ExpressionEvaluationException(
-              String.format("Invalid Function Argument:%s", argName));
-      }
-    });
+    arguments.forEach(
+        arg -> {
+          String argName = ((NamedArgumentExpression) arg).getArgName();
+          Expression argValue = ((NamedArgumentExpression) arg).getValue();
+          ExprValue literalValue = argValue.valueOf();
+          switch (argName) {
+            case QUERY:
+              prometheusQueryRequest.setPromQl((String) literalValue.value());
+              break;
+            case STARTTIME:
+              prometheusQueryRequest.setStartTime(((Number) literalValue.value()).longValue());
+              break;
+            case ENDTIME:
+              prometheusQueryRequest.setEndTime(((Number) literalValue.value()).longValue());
+              break;
+            case STEP:
+              prometheusQueryRequest.setStep(literalValue.value().toString());
+              break;
+            default:
+              throw new ExpressionEvaluationException(
+                  String.format("Invalid Function Argument:%s", argName));
+          }
+        });
     return prometheusQueryRequest;
   }
-
 }