Address PR comments

Signed-off-by: Mitchell Gale <[email protected]>
opensearch-project · Aug 17, 2023 · aaf50ce · aaf50ce
1 parent dd72973
commit aaf50ce
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/integ-test/src/test/java/org/opensearch/sql/bwc/SQLBackwardsCompatibilityIT.java b/integ-test/src/test/java/org/opensearch/sql/bwc/SQLBackwardsCompatibilityIT.java
@@ -140,7 +140,7 @@ private void updateLegacySQLSettings() throws IOException {
     request.setJsonEntity(
         String.format(
             Locale.ROOT,
-            "{\n" + "  \"persistent\" : {\n" + "    \"%s\" : \"%s\"\n" + "  }\n" + "}",
+            "{\n" + "  \"persistent\" : {\n    \"%s\" : \"%s\"\n  }\n}",
             "opendistro.sql.cursor.keep_alive",
             "7m"));
 
@@ -193,7 +193,7 @@ private void verifySQLQueries(String endpoint) throws IOException {
 
   private JSONObject executeSQLQuery(String endpoint, String query) throws IOException {
     Request request = new Request("POST", endpoint);
-    request.setJsonEntity(String.format(Locale.ROOT, "{" + "  \"query\" : \"%s\"" + "}", query));
+    request.setJsonEntity(String.format(Locale.ROOT, "{  \"query\" : \"%s\"}", query));
 
     RequestOptions.Builder restOptionsBuilder = RequestOptions.DEFAULT.toBuilder();
     restOptionsBuilder.addHeader("Content-Type", "application/json");

diff --git a/integ-test/src/test/java/org/opensearch/sql/legacy/RestIntegTestCase.java b/integ-test/src/test/java/org/opensearch/sql/legacy/RestIntegTestCase.java
@@ -83,10 +83,10 @@ protected boolean preserveClusterUponCompletion() {
   /**
    * We need to be able to dump the jacoco coverage before cluster is shut down. The new internal
    * testing framework removed some of the gradle tasks we were listening to to choose a good time
-   * to do it. This will dump the executionData to file after each test. TODO: This is also
-   * currently just overwriting integTest.exec with the updated execData without resetting after
-   * writing each time. This can be improved to either write an exec file per test or by letting
-   * jacoco append to the file
+   * to do it. This will dump the executionData to file after each test.<br>
+   * TODO: This is also currently just overwriting integTest.exec with the updated execData without
+   * resetting after writing each time. This can be improved to either write an exec file per test
+   * or by letting jacoco append to the file
    */
   public interface IProxy {
     byte[] getExecutionData(boolean reset);
@@ -122,9 +122,9 @@ public static void dumpCoverage() {
   }
 
   /**
-   * As JUnit JavaDoc says: "The @AfterClass methods declared in superclasses will be run after
-   * those of the current class." So this method is supposed to run before closeClients() in parent
-   * class.
+   * As JUnit JavaDoc says:<br>
+   * "The @AfterClass methods declared in superclasses will be run after those of the current
+   * class." So this method is supposed to run before closeClients() in parent class.
    */
   @AfterClass
   public static void cleanUpIndices() throws IOException {