Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add Support for Field Star in Nested Function #1797

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport fa840e0 from #1773

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #1797 (a10dd52) into 2.x (2144ddd) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #1797      +/-   ##
============================================
+ Coverage     97.35%   97.36%   +0.01%     
- Complexity     4443     4459      +16     
============================================
  Files           388      388              
  Lines         10998    11048      +50     
  Branches        784      789       +5     
============================================
+ Hits          10707    10757      +50     
  Misses          284      284              
  Partials          7        7              
Flag Coverage Δ
sql-engine 97.36% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/opensearch/sql/analysis/Analyzer.java 100.00% <100.00%> (ø)
...rg/opensearch/sql/analysis/ExpressionAnalyzer.java 100.00% <100.00%> (ø)
...va/org/opensearch/sql/analysis/NestedAnalyzer.java 100.00% <100.00%> (ø)
...nsearch/sql/analysis/SelectExpressionAnalyzer.java 100.00% <100.00%> (ø)
...a/org/opensearch/sql/analysis/TypeEnvironment.java 100.00% <100.00%> (ø)
...rg/opensearch/sql/analysis/symbol/SymbolTable.java 100.00% <100.00%> (ø)
...pensearch/sql/sql/parser/AstExpressionBuilder.java 100.00% <100.00%> (ø)

@forestmvey forestmvey force-pushed the backport/backport-1773-to-2.x branch 2 times, most recently from 0c0d04e to 13b3a76 Compare June 28, 2023 21:58
* Add Support for Field Star in Nested Function.

Signed-off-by: forestmvey <[email protected]>

* Removing toString for NestedAllTupleFields.

Signed-off-by: forestmvey <[email protected]>

* Adding IT test for nested all fields in invalid clause of SQL statement.

Signed-off-by: forestmvey <[email protected]>

* Use utility function for checking is nested in NestedAnalyzer.

Signed-off-by: forestmvey <[email protected]>

* Formatting fixes.

Signed-off-by: forestmvey <[email protected]>

---------

Signed-off-by: forestmvey <[email protected]>
(cherry picked from commit fa840e0)
Signed-off-by: forestmvey <[email protected]>
@forestmvey forestmvey force-pushed the backport/backport-1773-to-2.x branch from 13b3a76 to a10dd52 Compare July 11, 2023 14:51
@forestmvey forestmvey merged commit 64f3d6c into 2.x Jul 11, 2023
21 of 22 checks passed
@github-actions github-actions bot deleted the backport/backport-1773-to-2.x branch July 11, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants