-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC] Set routing shard in SQL via the relation partition #1808
Closed
acarbonetto
wants to merge
16
commits into
opensearch-project:main
from
Bit-Quill:dev-metafields-set-routing-shard
Closed
[PoC] Set routing shard in SQL via the relation partition #1808
acarbonetto
wants to merge
16
commits into
opensearch-project:main
from
Bit-Quill:dev-metafields-set-routing-shard
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: acarbonetto <[email protected]>
…uting Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: acarbonetto <[email protected]>
acarbonetto
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey and
GumpacG
as code owners
July 5, 2023 04:58
Codecov Report
@@ Coverage Diff @@
## main #1808 +/- ##
============================================
- Coverage 97.39% 94.30% -3.10%
+ Complexity 4603 946 -3657
============================================
Files 401 100 -301
Lines 11397 2772 -8625
Branches 835 241 -594
============================================
- Hits 11100 2614 -8486
+ Misses 290 154 -136
+ Partials 7 4 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* Fix core refactor: StreamIO from common to core.common Signed-off-by: acarbonetto <[email protected]> * Fix core refactor: StreamIO from common to core.common Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: acarbonetto <[email protected]>
…routing-shard Signed-off-by: acarbonetto <[email protected]>
Closing Proof of Concept |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows user to set routing shard via the relation partition keys. For example:
Note that multiple keys can be send to OpenSearch storage by using comma-delimited list.
TODO
Issues Resolved
Note (out of scope): PPL syntax is still TBD
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.