Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix core refactor: StreamIO from common to core.common (#296) #1869

Merged

Conversation

acarbonetto
Copy link
Collaborator

Description

Fix compilation errors after opensearch-project/OpenSearch#8157.

Note: May need backport 2.x label.

In this PR it's only changing package name of core classes in import section

Issues Resolved

Fixes changes from opensearch-project/ml-commons#1122

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Fix core refactor: StreamIO from common to core.common

Signed-off-by: acarbonetto <[email protected]>

* Fix core refactor: StreamIO from common to core.common

Signed-off-by: acarbonetto <[email protected]>

---------

Signed-off-by: acarbonetto <[email protected]>
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #1869 (372ef91) into main (fa51012) will not change coverage.
The diff coverage is n/a.

❗ Current head 372ef91 differs from pull request most recent head 0a2f6d7. Consider uploading reports for the commit 0a2f6d7 to get more accurate results

@@            Coverage Diff            @@
##               main    #1869   +/-   ##
=========================================
  Coverage     97.39%   97.39%           
  Complexity     4602     4602           
=========================================
  Files           401      401           
  Lines         11386    11386           
  Branches        843      843           
=========================================
  Hits          11089    11089           
  Misses          290      290           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...earch/sql/datasources/exceptions/ErrorMessage.java 0.00% <ø> (ø)
...model/transport/CreateDataSourceActionRequest.java 27.27% <ø> (ø)
...odel/transport/CreateDataSourceActionResponse.java 0.00% <ø> (ø)
...model/transport/DeleteDataSourceActionRequest.java 18.75% <ø> (ø)
...odel/transport/DeleteDataSourceActionResponse.java 0.00% <ø> (ø)
...es/model/transport/GetDataSourceActionRequest.java 27.27% <ø> (ø)
...s/model/transport/GetDataSourceActionResponse.java 0.00% <ø> (ø)
...model/transport/UpdateDataSourceActionRequest.java 27.27% <ø> (ø)
...odel/transport/UpdateDataSourceActionResponse.java 0.00% <ø> (ø)
...ql/datasources/rest/RestDataSourceQueryAction.java 0.00% <ø> (ø)
... and 7 more

Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore BWC failures

@acarbonetto acarbonetto merged commit dae5a85 into opensearch-project:main Jul 14, 2023
13 of 15 checks passed
@acarbonetto acarbonetto deleted the integ-fix-streamioNamespace branch July 14, 2023 16:29
matthewryanwells pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 14, 2023
…arch-project#1869)

* Fix core refactor: StreamIO from common to core.common



* Fix core refactor: StreamIO from common to core.common



---------

Signed-off-by: acarbonetto <[email protected]>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 20, 2023
…arch-project#1869)

* Fix core refactor: StreamIO from common to core.common

* Fix core refactor: StreamIO from common to core.common

---------

Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 20, 2023
…arch-project#1869)

* Fix core refactor: StreamIO from common to core.common

* Fix core refactor: StreamIO from common to core.common

---------

Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 20, 2023
* Fix core refactor: StreamIO from common to core.common

* Fix core refactor: StreamIO from common to core.common

---------

Signed-off-by: acarbonetto <[email protected]>
(cherry picked from commit dae5a85)
vamsi-amazon added a commit that referenced this pull request Jul 26, 2023
…#296) (#1891)

* Fix core refactor: StreamIO from common to core.common (#296) (#1869)

* Fix core refactor: StreamIO from common to core.common

* Fix core refactor: StreamIO from common to core.common

---------

Signed-off-by: acarbonetto <[email protected]>
(cherry picked from commit dae5a85)

* Bump Version and Fix import error

Signed-off-by: Vamsi Manohar <[email protected]>

---------

Signed-off-by: Vamsi Manohar <[email protected]>
Co-authored-by: Andrew Carbonetto <[email protected]>
Co-authored-by: Vamsi Manohar <[email protected]>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 28, 2023
…arch-project#1869)

* Fix core refactor: StreamIO from common to core.common

* Fix core refactor: StreamIO from common to core.common

---------

Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants