Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Create new session if client provided session is invalid (#2368) #2393

Merged

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Oct 30, 2023

Backport #2368

  • Create new session if session is invalid

Signed-off-by: Peng Huo [email protected]

  • fix code style

Signed-off-by: Peng Huo [email protected]

  • fix UT

Signed-off-by: Peng Huo [email protected]

  • fix error response

Signed-off-by: Peng Huo [email protected]


Signed-off-by: Peng Huo [email protected]
(cherry picked from commit e16da37)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…project#2368)

* Create new session if session is invalid

Signed-off-by: Peng Huo <[email protected]>

* fix code style

Signed-off-by: Peng Huo <[email protected]>

* fix UT

Signed-off-by: Peng Huo <[email protected]>

* fix error response

Signed-off-by: Peng Huo <[email protected]>

---------

Signed-off-by: Peng Huo <[email protected]>
(cherry picked from commit e16da37)
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #2393 (19ff213) into 2.x (59e36a7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #2393      +/-   ##
============================================
- Coverage     95.61%   95.61%   -0.01%     
  Complexity     4955     4955              
============================================
  Files           469      469              
  Lines         13836    13835       -1     
  Branches        918      918              
============================================
- Hits          13229    13228       -1     
  Misses          587      587              
  Partials         20       20              
Flag Coverage Δ
sql-engine 95.61% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rch/sql/spark/dispatcher/SparkQueryDispatcher.java 100.00% <100.00%> (ø)
.../sql/spark/execution/statement/StatementModel.java 98.03% <ø> (ø)

@penghuo penghuo merged commit 56bd9dc into opensearch-project:2.x Oct 30, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants