Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Adding documentation for F5 NGINX Ingress controller #451

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jasonwilliams14
Copy link

This is a guide on how to use F5 NGINX Ingress controller with open service mesh. The document works with both NGINX Ingress Controller OSS and NGINX Ingress Controller Plus.
The document also covers how to setup this integration using the sidecar method and the ingressBackend method.

@jasonwilliams14 jasonwilliams14 requested review from a team as code owners February 24, 2023 22:20
@netlify
Copy link

netlify bot commented Feb 24, 2023

Deploy Preview for osm-docs ready!

Name Link
🔨 Latest commit 9754ca5
🔍 Latest deploy log https://app.netlify.com/sites/osm-docs/deploys/645e607e097a7600080b834c
😎 Deploy Preview https://deploy-preview-451--osm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jasonwilliams14 jasonwilliams14 force-pushed the docs/f5-nginx-ingress-controller branch from c407131 to 2fa8d80 Compare February 24, 2023 22:22
@phillipgibson
Copy link
Contributor

Thanks @jasonwilliams14 for submitting this. I'll take a look at this for the upcoming week.

@jasonwilliams14
Copy link
Author

Thanks @jasonwilliams14 for submitting this. I'll take a look at this for the upcoming week.

You bet. I might add or update some of the doc. There are a few other tests that I am curious to test. Will update if anything comes up.

@jasonwilliams14 jasonwilliams14 force-pushed the docs/f5-nginx-ingress-controller branch 2 times, most recently from d5ccb51 to 544182a Compare March 1, 2023 00:29
@phillipgibson
Copy link
Contributor

phillipgibson commented Mar 7, 2023

@jasonwilliams14 can you update on how nginx is installed? The doc jumps right over that.

@jasonwilliams14
Copy link
Author

@jasonwilliams14 can you update on how nginx is installed? The doc jumps right over that.

@phillipgibson Sure. I would be happy to update the guide to include the installation of NGINX Ingress controller. Let me get started on that and update my PR.

@jasonwilliams14 jasonwilliams14 force-pushed the docs/f5-nginx-ingress-controller branch from 544182a to 418a15d Compare March 17, 2023 19:28
@jasonwilliams14
Copy link
Author

@phillipgibson I updated the doc to cover the installation of F5 NGINX Ingress controller.
Let me know if you need anything else.

@phillipgibson
Copy link
Contributor

@phillipgibson I updated the doc to cover the installation of F5 NGINX Ingress controller. Let me know if you need anything else.

Taking a look today.

@jasonwilliams14 jasonwilliams14 force-pushed the docs/f5-nginx-ingress-controller branch from 418a15d to f7dd99a Compare March 23, 2023 19:25
@jasonwilliams14
Copy link
Author

@phillipgibson I updated the doc to cover the installation of F5 NGINX Ingress controller. Let me know if you need anything else.

Taking a look today.

@phillipgibson I updated the PR today and added more detail about how to install F5 NGINX Ingress controller.

I added the necessary document front matter and was trying to properly format each section title. The section titles will need to be configured correctly to ensure the content is associated correctly with the proper formatting.
@phillipgibson
Copy link
Contributor

@jasonwilliams14 please see this preview to see if the page sections are formatted correctly. https://deploy-preview-451--osm-docs.netlify.app/docs/demos/f5_nginx_ingress_controller/

@jasonwilliams14
Copy link
Author

@jasonwilliams14 please see this preview to see if the page sections are formatted correctly. https://deploy-preview-451--osm-docs.netlify.app/docs/demos/f5_nginx_ingress_controller/

@phillipgibson This looks good. Thank you very much!

@phillipgibson
Copy link
Contributor

@jasonwilliams14 I'm going to run through this for verification. You'll need to sign your commits with DCO. Have a look at https://github.com/openservicemesh/osm-docs/blob/main/CONTRIBUTING.md#sign-your-work for the procedure.

@jasonwilliams14
Copy link
Author

@jasonwilliams14 I'm going to run through this for verification. You'll need to sign your commits with DCO. Have a look at https://github.com/openservicemesh/osm-docs/blob/main/CONTRIBUTING.md#sign-your-work for the procedure.

I believe my commit is signed as I reviewed the commit history. It does not look like your commit is signed?

I can squash the commits and sign it if that is helpful. Happy to do so. Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants