This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
feat(ci): create GitHub release workflow #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsonshi
force-pushed
the
create-gh-release-workflow
branch
from
ce8d1cd to
30511f2
Compare
|
Builds binaries in top-level Linux testing: Windows testing: |
Signed-off-by: Johnson Shi <[email protected]>
johnsonshi
force-pushed
the
create-gh-release-workflow
branch
from
30511f2 to
29475e3
Compare
Codecov Report
@@ Coverage Diff @@
## main #121 +/- ##
=======================================
Coverage 42.51% 42.51%
=======================================
Files 29 29
Lines 1249 1249
=======================================
Hits 531 531
Misses 718 718
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
johnsonshi
commented
Jan 3, 2022
pkg/osm/version/types_test.go
Outdated
| @@ -15,7 +15,7 @@ func TestEnvoyConfigParser(t *testing.T) { | |||
| assert := tassert.New(t) | |||
| actual := getReleases() | |||
|
|
|||
| assert.Equal([]string{"v0.10", "v0.11", "v0.6", "v0.7", "v0.8", "v0.9"}, actual) | |||
| assert.Equal([]string{"v0.10", "v0.11", "v0.7", "v0.8", "v0.9"}, actual) | |||
There was a problem hiding this comment.
Needed to pass unit tests as v0.6 is not supported anymore.
jaellio
reviewed
Jan 12, 2022
| runs-on: ubuntu-latest | ||
| needs: version | ||
| env: | ||
| # VERSION: ${{ needs.version.outputs.version }} |
There was a problem hiding this comment.
Why is this commented out?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates GitHub release workflow and build-cross dist Makefile target
Resolves #109
Signed-off-by: Johnson Shi [email protected]