check(osm): Check for bad logs in osm controller pods #50
Conversation
johnsonshi
force-pushed
the
osm-controller-log-no-error
branch
2 times, most recently
from
e24b6f5 to
592627a
Compare
| if err != nil { | ||
| log.Err(err).Msg("Error creating Kubernetes client") | ||
| } | ||
|
|
||
| // TODO add checks like osm controller log checks | ||
| outcomes := common.Run() | ||
| outcomes := common.Run(HasNoBadOsmControllerLogsCheck(client, osmControlPlaneNamespace)) |
There was a problem hiding this comment.
I think HasNoBadOsmControllerLogsCheck could be used in pod-to-pod check... and issue a warning if something is fishy...
There was a problem hiding this comment.
| } | ||
|
|
||
| return nil | ||
| return podhelper.HasNoBadLogs(check.client, check.pod, "envoy") |
There was a problem hiding this comment.
@draychev Regarding your comment https://github.com/openservicemesh/osm-health/pull/50/files#r683754375
Both osm-health connectivity pod-to-pod srcPod destPod and the osm-health control-plane status now use podhelper.HasNoBadLogs.
See the following code:
(This one, checking envoy container logs, is invoked as part of pod to pod)
https://github.com/openservicemesh/osm-health/pull/50/files#diff-533a363c43aa9facdfece27a0c8e9d31a8c22ec541dd4d172d6c782d10eb9c68R37
(This one is used in the control-plane status check for osm-controller log issues)
https://github.com/openservicemesh/osm-health/pull/50/files#diff-d4f2e551640a295a560017296694c7c15fb6f0c302dfd34c013894ddb0c893ddR51-R57
Signed-off-by: Johnson Shi <[email protected]>
Signed-off-by: Johnson Shi <[email protected]>
Signed-off-by: Johnson Shi <[email protected]>
johnsonshi
force-pushed
the
osm-controller-log-no-error
branch
from
be6bea9 to
bf9a31a
Compare
* check(osm): Check for bad logs in osm controller pods Signed-off-by: Johnson Shi <[email protected]> * Refactor osm-controller pod error handling and logging Signed-off-by: Johnson Shi <[email protected]> * Remove unused logger Signed-off-by: Johnson Shi <[email protected]>
Signed-off-by: Johnson Shi [email protected]