Updating frontend-component libs and add stripAllPfStyles flag to fec.config.js #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ammont82 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
size/XS
openshift-ci
bot
added
size/S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to solve CSS conflicts in the OCM UI. We have a solution which is not ideal but will unblock you. The problem is that the assisted installer app, depends on the assisted installer UI and depends on the openshift plugin SDK. Which still requires pf4.
This makes a real mess with dependency deduplication. It means the assisted installer UI has several instances of PF installed within node modules, which makes a kind of a mess in certain webpack config that is tasked with removing PF styles dependencies from HCC UI modules.
To solve this @Hyperkid123 propose this temporary solution: RedHatInsights/frontend-components#2019