Skip to content

HYPERFLEET-755 - fix: correct Health CEL expression in adapter failure test #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 3 commits into from
Mar 23, 2026
Merged

HYPERFLEET-755 - fix: correct Health CEL expression in adapter failure test #52

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7683182
HYPERFLEET-755 - fix: correct Health CEL expression in adapter failur…
tzhou5 Mar 20, 2026
9b437fe
correct Health CEL expression
tzhou5 Mar 20, 2026
79847ae
correct Health CEL expression in adapter failure test
tzhou5 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions testdata/adapter-configs/cl-precondition-error/adapter-task-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,21 @@ post:
- type: "Health"
status:
expression: |
adapter.?executionStatus.orValue("") == "success" ? "True" : "False"
adapter.?executionStatus.orValue("") == "success"
&& !(adapter.?resourcesSkipped.orValue(false) && adapter.?errorReason.orValue("") != "")
? "True" : "False"
reason:
expression: |
adapter.?errorReason.orValue("") != "" ? adapter.?errorReason.orValue("") : "Healthy"
adapter.?executionStatus.orValue("") != "success"
? "ExecutionFailed"
: adapter.?errorReason.orValue("") != ""
? adapter.?errorReason.orValue("")
: "Healthy"
message:
expression: |
Copy link
Contributor

@rafabene rafabene Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Category: Bug

The message.expression doesn't account for the new ExecutionFailed reason path. When
executionStatus != "success" and errorMessage is empty, the message defaults to "All adapter operations completed successfully" — which contradicts the "False" status and
"ExecutionFailed" reason.

The cl-maestro adapter config already handles this with a 3-way ternary. Consider matching
that pattern:

message:
  expression: |
    adapter.?executionStatus.orValue("") != "success"
      ? adapter.?errorMessage.orValue("Adapter execution failed")
      : adapter.?errorMessage.orValue("") != ""
        ? adapter.?errorMessage.orValue("")
        : "All adapter operations completed successfully"

This way, execution failures always get a meaningful message even if errorMessage is empty.

Copy link
Contributor Author

@tzhou5 tzhou5 Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

adapter.?errorMessage.orValue("") != "" ? adapter.?errorMessage.orValue("") : "All adapter operations completed successfully"
adapter.?errorMessage.orValue("") != ""
? adapter.?errorMessage.orValue("")
: "All adapter operations completed successfully"
observed_generation:
expression: "1"
observed_time: "{{ now | date \"2006-01-02T15:04:05Z07:00\" }}"
Expand Down