Skip to content

Commit

Permalink
Add a note to FilterServiceTypes func
Browse files Browse the repository at this point in the history
  • Loading branch information
sabinaaledort committed May 12, 2024
1 parent b4472bb commit cf3bd81
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions endpointslices/filter.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ func FilterHostNetwork(epInfo EndpointSlicesInfo) bool {
}

// FilterServiceTypes checks if the service behind the endpointSlice is of type LoadBalancer or NodePort.
// Skip ClusterIP services which provide internal connectivity only

Check failure on line 61 in endpointslices/filter.go

View workflow job for this annotation

GitHub Actions / unit-test

Comment should end in a period (godot)
func FilterServiceTypes(epInfo EndpointSlicesInfo) bool {
if epInfo.Service.Spec.Type != corev1.ServiceTypeLoadBalancer &&
epInfo.Service.Spec.Type != corev1.ServiceTypeNodePort {
Expand Down

0 comments on commit cf3bd81

Please sign in to comment.