Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ComMatrix method; Changed private func to public #17

Closed
wants to merge 3 commits into from
Closed

Added ComMatrix method; Changed private func to public #17

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f5e0f7
Added ComMatrix method; Changed private func to public
shirmoran Jul 16, 2024
85e1259
linting changes
shirmoran Jul 16, 2024
235d8eb
move equals func to origin repo
shirmoran Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions commatrix/commatrix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func New(kubeconfigPath string, customEntriesPath string, customEntriesFormat st
if err != nil {
return nil, fmt.Errorf("failed adding custom entries: %s", err)
}
customComDetails, err := addFromFile(customEntriesPath, inputFormat)
customComDetails, err := AddFromFile(customEntriesPath, inputFormat)
if err != nil {
return nil, fmt.Errorf("failed adding custom entries: %s", err)
}
Expand All @@ -81,7 +81,7 @@ func New(kubeconfigPath string, customEntriesPath string, customEntriesFormat st
return &types.ComMatrix{Matrix: cleanedComDetails}, nil
}

func addFromFile(fp string, format types.Format) ([]types.ComDetails, error) {
func AddFromFile(fp string, format types.Format) ([]types.ComDetails, error) {
var res []types.ComDetails
f, err := os.Open(filepath.Clean(fp))
if err != nil {
Expand Down
Loading