creating a unit test using mocking for the generate SS function#20
Closed
aabughosh wants to merge 13 commits intoopenshift-kni:mainfrom
Closed
creating a unit test using mocking for the generate SS function#20aabughosh wants to merge 13 commits intoopenshift-kni:mainfrom
aabughosh wants to merge 13 commits intoopenshift-kni:mainfrom
Conversation
update the function: remove unused vars and update the debug object to use the mock functions on test
sebrandon1
reviewed
Jul 29, 2024
sebrandon1
reviewed
Jul 29, 2024
sebrandon1
approved these changes
Jul 31, 2024
Contributor
sebrandon1
left a comment
sebrandon1
left a comment
There was a problem hiding this comment.
Seems to be okay as far as unit tests go. The only functional changes just move parameters from struct to interface which is fine.
sebrandon1
reviewed
Jul 31, 2024
Co-authored-by: Brandon Palm <bpalm@redhat.com>
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update the function: remove unused vars
and update the debug object to use the mock functions on test