Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generating commatrix from csv and fix samples #21

Merged

Conversation

shirmoran
Copy link
Collaborator

The node role header of a commatrix in the csv format, defers from those of types json and yaml (Node Role instead of nodeRole). So, csv annotations in ComDetails struct were added.

The previous custom entries examples had some incorrect parameters which were fixed:

  1. example-custom-entries.csv: NodeRole column was changed to Node Rule (as in the documented commatrix.
  2. example-custom-entries.yaml and example-custom-entries.json: port was changed from a string to an int (9050 instead of "9050" for example).

a unit test applying the custom entries samples will be added in a separate PR.

@shirmoran shirmoran requested a review from sabinaaledort July 29, 2024 13:40
@shirmoran shirmoran force-pushed the fix-generate-commatrix-from-file branch from 2ff39b1 to 37bd46c Compare July 31, 2024 10:09
cmd/main.go Outdated Show resolved Hide resolved
@shirmoran shirmoran requested a review from sabinaaledort July 31, 2024 12:00
Copy link

@sebrandon1 sebrandon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about params

commatrix/generate.go Outdated Show resolved Hide resolved
commatrix/generate.go Outdated Show resolved Hide resolved
@sabinaaledort sabinaaledort merged commit 20db006 into openshift-kni:main Aug 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants