-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow generating commatrix from csv and fix samples #21
Merged
sabinaaledort
merged 10 commits into
openshift-kni:main
from
shirmoran:fix-generate-commatrix-from-file
Aug 4, 2024
Merged
Allow generating commatrix from csv and fix samples #21
sabinaaledort
merged 10 commits into
openshift-kni:main
from
shirmoran:fix-generate-commatrix-from-file
Aug 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirmoran
force-pushed
the
fix-generate-commatrix-from-file
branch
from
July 31, 2024 10:09
2ff39b1
to
37bd46c
Compare
sebrandon1
reviewed
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment about params
aabughosh
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node role header of a commatrix in the csv format, defers from those of types json and yaml (
Node Role
instead ofnodeRole
). So, csv annotations inComDetails
struct were added.The previous custom entries examples had some incorrect parameters which were fixed:
NodeRole
column was changed toNode Rule
(as in the documented commatrix.a unit test applying the custom entries samples will be added in a separate PR.