Sort commatrix by node role, protocol and port #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabinaaledort
force-pushed
the
sort_commatrix
branch
from
1ad046b to
c2e4916
Compare
sabinaaledort
force-pushed
the
sort_commatrix
branch
from
ee7fdaa to
fc75215
Compare
sabinaaledort
force-pushed
the
sort_commatrix
branch
3 times, most recently
from
455e188 to
6e5fe36
Compare
oribon
reviewed
May 28, 2024
types/types.go
Outdated
| Service string `json:"Service"` | ||
| Pod string `json:"Pod"` | ||
| Container string `json:"Container"` | ||
| NodeRole string `json:"Node Role"` |
There was a problem hiding this comment.
I think the space here is wrong (in the json:), also is there a reason for the uppercase change in the rest?
types/types.go
Outdated
| @@ -78,14 +78,14 @@ func (m *ComMatrix) String() string { | |||
| } | |||
|
|
|||
| func (cd ComDetails) String() string { | |||
| return fmt.Sprintf("%s,%s,%s,%s,%s,%s,%s,%s,%v", cd.Direction, cd.Protocol, cd.Port, cd.Namespace, cd.Service, cd.Pod, cd.Container, cd.NodeRole, cd.Optional) | |||
| return fmt.Sprintf("%s,%s,%d,%s,%s,%s,%s,%s,%v", cd.Direction, cd.Protocol, cd.Port, cd.Namespace, cd.Service, cd.Pod, cd.Container, cd.NodeRole, cd.Optional) | |||
| } | |||
|
|
|||
| func RemoveDups(outPuts []ComDetails) []ComDetails { | |||
There was a problem hiding this comment.
nit: it seems this and the CmpComDetails are called together, wdyt about just combining them into one function that remove dups and sorts?
cmd/main.go
Outdated
| } | ||
| } | ||
|
|
||
| func diff(mat types.ComMatrix, ssMat types.ComMatrix) string { |
There was a problem hiding this comment.
the name can be changed to something clearer, also is ssMat still correct here? can this just be mat1,mat2?
sabinaaledort
force-pushed
the
sort_commatrix
branch
from
6e5fe36 to
8650b45
Compare
sabinaaledort
force-pushed
the
sort_commatrix
branch
from
8650b45 to
b3c0099
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort commatrix by node role, protocol and port and fix ss filter causing missing UDP ports