cnf-network: add multi-netpolicy tests for ipvlan cni #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkopels
reviewed
Dec 22, 2024
| By("Enable MultiNetworkPolicy support") | ||
| enableMultiNetworkPolicy(true) | ||
|
|
||
| By("Deploy Test Resources: 2 Namespaces") |
There was a problem hiding this comment.
IMO rather then the number 2 use two.
| WithLabel("ns", "ns2").Create() | ||
| Expect(err).ToNot(HaveOccurred(), "Failed to create test namespace") | ||
|
|
||
| By("Deploy Test Resources: 2 NADs for IPVLAN CNI") |
There was a problem hiding this comment.
same here By("Deploy Test Resources: two NADs for IPVLAN CNI"
| defineAndCreateIpvlanNAD("ipvlan", testNs1, sriovInterfacesUnderTest[0]) | ||
| defineAndCreateIpvlanNAD("ipvlan", testNs2, sriovInterfacesUnderTest[1]) | ||
|
|
||
| By("Deploy Test Resources: 5 Pods") |
There was a problem hiding this comment.
It is generally best to write out numbers from zero to 10 in technical writing. So that goes for where ever you used numbers rather then writing them out. Up to you.
There was a problem hiding this comment.
Ok, Updated accordingly.
evgenLevin
reviewed
Dec 23, 2024
|
|
||
| const ( | ||
| testNs1, testNs2 = "policy-ns1", "policy-ns2" | ||
| pod1, pod2, pod3, pod4, pod5 = "pod1", "pod2", "pod3", "pod4", "pod5" |
There was a problem hiding this comment.
I can see only one time use. If it's true remove var, if not please rename var to podname1
|
|
||
| By("Check ingress traffic to pod1 from other four pods. All ports should be open") | ||
|
|
||
| verifyPaths(testPod2, testPod1, allOpen, allOpen, testData) |
There was a problem hiding this comment.
Could you move all common func to the internal folder or create a common.go (check the metallb implementation)?
Comment on lines
28
to
51
| var ( | ||
| sriovInterfacesUnderTest []string | ||
| tNs1, tNs2 *namespace.Builder | ||
| testPod1, testPod2, testPod3, testPod4, testPod5 *pod.Builder | ||
| ports = []string{"5001", "5002", "5003"} | ||
| protocols = []string{"tcp", "tcp", "udp"} | ||
| allOpen = map[string]string{"5001": "pass", "5002": "pass", "5003": "pass"} | ||
| allClose = map[string]string{"5001": "fail", "5002": "fail", "5003": "fail"} | ||
| p5001Open = map[string]string{"5001": "pass", "5002": "fail", "5003": "fail"} | ||
| p5001p5002Open = map[string]string{"5001": "pass", "5002": "pass", "5003": "fail"} | ||
| ) | ||
|
|
||
| const ( | ||
| testNs1, testNs2 = "policy-ns1", "policy-ns2" | ||
| pod1, pod2, pod3, pod4, pod5 = "pod1", "pod2", "pod3", "pod4", "pod5" | ||
| ) | ||
|
|
||
| testData := podsData{ | ||
| "pod1": {IPv4: "192.168.10.10/24", IPv6: "2001:0:0:1::10/64", Protocols: protocols, Ports: ports}, | ||
| "pod2": {IPv4: "192.168.10.11/24", IPv6: "2001:0:0:1::11/64", Protocols: protocols, Ports: ports}, | ||
| "pod3": {IPv4: "192.168.10.12/24", IPv6: "2001:0:0:1::12/64", Protocols: protocols, Ports: ports}, | ||
| "pod4": {IPv4: "192.168.20.11/24", IPv6: "2001:0:0:2::11/64", Protocols: protocols, Ports: ports}, | ||
| "pod5": {IPv4: "192.168.20.12/24", IPv6: "2001:0:0:2::12/64", Protocols: protocols, Ports: ports}, | ||
| } |
There was a problem hiding this comment.
It looks like you used very similar var and const in the bond tests. If so, could you move them to the internal folder?
Comment on lines
80
to
81
| defineAndCreateIpvlanNAD("ipvlan", testNs1, sriovInterfacesUnderTest[0]) | ||
| defineAndCreateIpvlanNAD("ipvlan", testNs2, sriovInterfacesUnderTest[1]) |
There was a problem hiding this comment.
Suggested change
| defineAndCreateIpvlanNAD("ipvlan", testNs1, sriovInterfacesUnderTest[0]) | |
| defineAndCreateIpvlanNAD("ipvlan", testNs2, sriovInterfacesUnderTest[1]) | |
| defineAndCreateIpvlanNAD(testNs1, sriovInterfacesUnderTest[0]) | |
| defineAndCreateIpvlanNAD(testNs2, sriovInterfacesUnderTest[1]) |
| defineAndCreateIpvlanNAD("ipvlan", testNs2, sriovInterfacesUnderTest[1]) | ||
|
|
||
| By("Deploy Test Resources: Five Pods") | ||
| testPod1 = defineAndCreatePodWithIpvlanIf(pod1, testNs1, workerNodeList[0].Object.Name, testData) |
There was a problem hiding this comment.
Suggested change
| testPod1 = defineAndCreatePodWithIpvlanIf(pod1, testNs1, workerNodeList[0].Object.Name, testData) | |
| testPod1 = defineAndCreatePodWithIpvlanIf(pod1, testNs1, testData) |
evgenLevin
reviewed
Dec 24, 2024
Comment on lines
52
to
57
| // AllClose represents that all what ports are expected to be open for policy tests. | ||
| AllClose = map[string]string{"5001": "fail", "5002": "fail", "5003": "fail"} | ||
| // P5001Open represents that all what ports are expected to be open for policy tests. | ||
| P5001Open = map[string]string{"5001": "pass", "5002": "fail", "5003": "fail"} | ||
| // P5001p5002Open represents that all what ports are expected to be open for policy tests. | ||
| P5001p5002Open = map[string]string{"5001": "pass", "5002": "pass", "5003": "fail"} |
There was a problem hiding this comment.
Please fix the comments
gkopels
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multinetpolicy_ipvlan.goMulti-NetworkPolicy IPVLAN CNI Tests