Skip to content

AA: e2e: wire TLS suite into runner and Makefile#4004

Open
shajmakh wants to merge 1 commit into
openshift-kni:mainfrom
shajmakh:fix-us-ci
Open

AA: e2e: wire TLS suite into runner and Makefile#4004
shajmakh wants to merge 1 commit into
openshift-kni:mainfrom
shajmakh:fix-us-ci

Conversation

@shajmakh
Copy link
Copy Markdown
Member

Add binary-e2e-tls and build-e2e-tls targets, include the TLS test binary in binary-e2e-all, and run e2e-nrop-tls.test after the scheduler install suite in hack/run-test-e2e.sh. Skip the TLS suite in BeforeSuite when the OpenShift APIServer API is unavailable so kind-based CI is not broken.

Assisted-by: Cursor (Composer)
AI-attribution: AIA EAI Hin R cursor-composer v1

Add binary-e2e-tls and build-e2e-tls targets, include the TLS test binary in
binary-e2e-all, and run e2e-nrop-tls.test after the scheduler install suite in
hack/run-test-e2e.sh. Skip the TLS suite in BeforeSuite when the OpenShift
APIServer API is unavailable so kind-based CI is not broken.

Assisted-by: Cursor (Composer)
AI-attribution: AIA EAI Hin R cursor-composer v1
Signed-off-by: Shereen Haj <shajmakh@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci openshift-ci Bot requested review from Tal-or and mrniranjan May 12, 2026 12:59
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 15e01291-cfc5-4605-8796-2352d7c3a5f6

📥 Commits

Reviewing files that changed from the base of the PR and between 67e6da3 and 156c0a2.

📒 Files selected for processing (3)
  • Makefile
  • hack/run-test-e2e.sh
  • test/e2e/tls/tls_suite_test.go

📝 Walkthrough

Walkthrough

This PR adds build targets, test suite setup, and runner integration for a new TLS e2e test suite. The Makefile defines compilation targets, the test suite adds a cluster capability check to skip gracefully on clusters without OpenShift APIServer TLS profile support, and the runner script wires the compiled test binary into the existing e2e execution pipeline.

Changes

TLS e2e test suite support

Layer / File(s) Summary
Build targets for TLS e2e tests
Makefile
binary-e2e-tls target compiles the TLS e2e test binary from ./test/e2e/tls. The binary-e2e-all target is updated to include it. A new build-e2e-tls target adds fmt and vet prerequisites before building.
TLS suite APIServer availability check
test/e2e/tls/tls_suite_test.go
Imports expanded to include context, OpenShift config API types, and controller-runtime helpers. BeforeSuite now creates a context, fetches the APIServer resource, and skips the suite if the TLS profile is unavailable; other fetch errors fail setup.
Test runner TLS execution
hack/run-test-e2e.sh
A new TLS e2e execution step is added under the ENABLE_SCHED_TESTS block after scheduler install tests. It runs the compiled e2e-nrop-tls.test binary with verbose ginkgo output, 1-hour timeout, fail-fast behavior, and writes results to e2e-tls.xml.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: wiring the TLS suite into the runner and Makefile, which aligns with the file modifications shown in the summary.
Description check ✅ Passed The description is directly related to the changeset, detailing the specific targets added, test integration, and conditional skip logic that correspond to the modifications shown in the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant