AA: e2e: wire TLS suite into runner and Makefile#4004
Conversation
Add binary-e2e-tls and build-e2e-tls targets, include the TLS test binary in binary-e2e-all, and run e2e-nrop-tls.test after the scheduler install suite in hack/run-test-e2e.sh. Skip the TLS suite in BeforeSuite when the OpenShift APIServer API is unavailable so kind-based CI is not broken. Assisted-by: Cursor (Composer) AI-attribution: AIA EAI Hin R cursor-composer v1 Signed-off-by: Shereen Haj <shajmakh@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shajmakh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR adds build targets, test suite setup, and runner integration for a new TLS e2e test suite. The Makefile defines compilation targets, the test suite adds a cluster capability check to skip gracefully on clusters without OpenShift APIServer TLS profile support, and the runner script wires the compiled test binary into the existing e2e execution pipeline. ChangesTLS e2e test suite support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add binary-e2e-tls and build-e2e-tls targets, include the TLS test binary in binary-e2e-all, and run e2e-nrop-tls.test after the scheduler install suite in hack/run-test-e2e.sh. Skip the TLS suite in BeforeSuite when the OpenShift APIServer API is unavailable so kind-based CI is not broken.
Assisted-by: Cursor (Composer)
AI-attribution: AIA EAI Hin R cursor-composer v1