Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alarm subscription readme #100

Conversation

Jennifer-chen-rh
Copy link
Collaborator

Readme update for alarm subscription server

@openshift-ci openshift-ci bot requested review from irinamihai and jhernand May 28, 2024 17:37
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Jennifer-chen-rh Jennifer-chen-rh force-pushed the main_alarm_sub_readme branch from 81c1674 to 0334123 Compare May 29, 2024 12:24
@Jennifer-chen-rh
Copy link
Collaborator Author

@jhernand @danielerez @irinamihai Any more comments? Can we merge it? thanks

@jhernand
Copy link
Collaborator

jhernand commented Jun 5, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
Copy link

openshift-ci bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhernand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 27c387a into openshift-kni:main Jun 5, 2024
8 checks passed
@Jennifer-chen-rh Jennifer-chen-rh deleted the main_alarm_sub_readme branch July 19, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants