-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Adds operator deployment steps in OpenShift #132
[doc] Adds operator deployment steps in OpenShift #132
Conversation
Angie and Irina would be the best ones to review this. |
b6b5360
to
89f950d
Compare
Comments addressed. PTAL. |
i have tried to test the CRs in this PR for instance the metadata Kind and also the api version seems wrong. |
@alosadagrande - it would be great if you could update this PR to address the comments and to incorporate the latest changes to how we deploy the operator. |
Signed-off-by: Alberto Losada <[email protected]>
c43b6d1
to
a8b232b
Compare
@bartwensley @alegacy could you open it again, sorry not sure how it happened :( |
67df9a2
to
ce1bd35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just a couple minor comments.
ce1bd35
to
d735e50
Compare
Addressed all comments. Thank you for your feedback |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alegacy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
This PR updates documentation:
Let me know your thoughts.