Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Adds operator deployment steps in OpenShift #132

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

alosadagrande
Copy link
Contributor

@alosadagrande alosadagrande commented Jul 30, 2024

This PR updates documentation:

  • It divides the README into two main blocks: deployment via operator in OpenShift and local deployment (testing)
  • Deployment of the IMS operator on top of OpenShift
  • Configuration of the different microservices of the IMS operator using the ORANO2MS CR. There was no example of that CR in the repo.
  • Currently only metadata, deployment manager and resource server. The rest could be added once they are validated in the operator deployment.
  • An index is added to ease navigation through the information

Let me know your thoughts.

@openshift-ci openshift-ci bot requested review from bartwensley and donpenney July 30, 2024 07:55
@bartwensley
Copy link
Collaborator

/cc @Missxiaoguo @irinamihai

Angie and Irina would be the best ones to review this.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@alosadagrande
Copy link
Contributor Author

Comments addressed. PTAL.

@mmorency2021
Copy link

i have tried to test the CRs in this PR for instance the metadata Kind and also the api version seems wrong.
from this discussion : https://redhat-internal.slack.com/archives/C07A9NFCS01/p1726609509792089
the new kind used is : Inventory. and the api version is : o2ims.oran.openshift.io/v1alpha1.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bartwensley
Copy link
Collaborator

bartwensley commented Nov 13, 2024

@alosadagrande - it would be great if you could update this PR to address the comments and to incorporate the latest changes to how we deploy the operator.

@alosadagrande alosadagrande force-pushed the doc-operator branch 6 times, most recently from c43b6d1 to a8b232b Compare November 15, 2024 11:45
@alosadagrande
Copy link
Contributor Author

@bartwensley @alegacy could you open it again, sorry not sure how it happened :(

@alegacy alegacy reopened this Nov 15, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@alosadagrande alosadagrande force-pushed the doc-operator branch 3 times, most recently from 67df9a2 to ce1bd35 Compare November 15, 2024 14:55
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@bartwensley bartwensley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just a couple minor comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@alosadagrande
Copy link
Contributor Author

Addressed all comments. Thank you for your feedback

@bartwensley
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@alegacy
Copy link
Collaborator

alegacy commented Nov 19, 2024

/approve

Copy link

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alegacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024
@alegacy
Copy link
Collaborator

alegacy commented Nov 19, 2024

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 0b09bc4 into openshift-kni:main Nov 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants