Import NodePool from the hardwaremanagement module #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tao Liu <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
A rebase should pick up the fixes to the unit tests that are failing here |
Signed-off-by: Don Penney <[email protected]>
In the current k8s dependencies, the fake client does not support
server-side apply calls and returns an error in the ginkgo tests:
[FAILED] Unexpected error:
<*errors.errorString | 0xc00064e1a0>:
apply patches are not supported in the fake client. Follow kubernetes/kubernetes#115598 for the current status
{
s: "apply patches are not supported in the fake client. Follow kubernetes/kubernetes#115598 for the current status",
}
occurred
This update adds a check for this error to bypass the failure, until the
k8s modules can be updated to a version that does not produce this
error.
Signed-off-by: Don Penney <[email protected]>
Signed-off-by: Don Penney <[email protected]>
* workflow: Update golangci-lint to 1.59.1 Signed-off-by: Don Penney <[email protected]> * Add initial golangci-lint config file Signed-off-by: Don Penney <[email protected]> --------- Signed-off-by: Don Penney <[email protected]>
Signed-off-by: Don Penney <[email protected]>
This addresses import statement ordering/grouping violations reported by the golintci tool. Signed-off-by: Allain Legacy <[email protected]>
This addresses issues with unnecessary type conversions reported by the golintci tool. Signed-off-by: Allain Legacy <[email protected]>
Signed-off-by: Don Penney <[email protected]>
Signed-off-by: Don Penney <[email protected]>
This addresses issues with improperly unwrapped error objects reported by the golintci tool. Signed-off-by: Allain Legacy <[email protected]>
This enables the code complexity test and addresses the violations reported by the golintci tool. Signed-off-by: Allain Legacy <[email protected]>
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I am going to create a new pull request for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NodePool component has been added to the hardwaremanagement module. This update adjusts all references within the oran-o2ims module to import NodePool from the hardwaremanagement module and remove any legacy imports from oran-o2ims.