Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenchen/main alert subscription #71

Conversation

Jennifer-chen-rh
Copy link
Collaborator

No description provided.

@Jennifer-chen-rh Jennifer-chen-rh marked this pull request as draft February 26, 2024 15:23
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2024
@Jennifer-chen-rh Jennifer-chen-rh force-pushed the jenchen/main_alert_subscription branch from 98e82b2 to 9dae506 Compare February 29, 2024 20:57
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 29, 2024
@Jennifer-chen-rh Jennifer-chen-rh changed the title Draft: Jenchen/main alert subscription Jenchen/main alert subscription Mar 1, 2024
@Jennifer-chen-rh Jennifer-chen-rh marked this pull request as ready for review March 4, 2024 18:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2024
@Jennifer-chen-rh Jennifer-chen-rh force-pushed the jenchen/main_alert_subscription branch from 9817f73 to ad2b625 Compare March 4, 2024 18:58
1. Start alarm subscription server, initialize the path, related registrations
2. Alarm subscription server basic resp api support for get, list, add, and delete
@Jennifer-chen-rh Jennifer-chen-rh force-pushed the jenchen/main_alert_subscription branch from 00c22f8 to ce964ae Compare March 4, 2024 21:32
@Jennifer-chen-rh
Copy link
Collaborator Author

@jhernand Could you please review the PR? Thanks

@jhernand
Copy link
Collaborator

jhernand commented Mar 8, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
Copy link

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhernand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3a24a17 into openshift-kni:main Mar 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants